Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 7/16/2022 10:10:03 AM #6907

Closed
performanceautofiler bot opened this issue Jul 28, 2022 · 1 comment
Closed

[Perf] Changes at 7/16/2022 10:10:03 AM #6907

performanceautofiler bot opened this issue Jul 28, 2022 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jul 28, 2022

Run Information

Architecture x64
OS Windows 10.0.18362
Baseline b6932fd190e1c1159cee7fa6c48a1dded66e0fd7
Compare 8e40ec4b629abe52b92b6d2665d87fc884cc3033
Diff Diff

Regressions in System.Linq.Tests.Perf_Enumerable

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
SequenceEqual - Duration of single invocation 22.14 ns 27.35 ns 1.24 0.40 False
Range - Duration of single invocation 430.80 ns 486.66 ns 1.13 0.03 False
ToArray - Duration of single invocation 773.23 ns 821.58 ns 1.06 0.05 False

graph
graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Linq.Tests.Perf_Enumerable*'

Payloads

Baseline
Compare

Histogram

System.Linq.Tests.Perf_Enumerable.SequenceEqual(input1: Array, input2: Array)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 27.345747428296054 > 23.074044778023836.
IsChangePoint: Marked as a change because one of 7/2/2022 7:35:06 PM, 7/6/2022 3:55:24 AM, 7/16/2022 8:09:48 AM, 7/18/2022 2:17:16 AM falls between 7/8/2022 10:31:34 AM and 7/18/2022 2:17:16 AM.
IsRegressionStdDev: Marked as regression because -4.451664810729164 (T) = (0 -29.354098440980067) / Math.Sqrt((18.824236669535114 / (78)) + (7.614533029340636 / (9))) is less than -1.988267907476882 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (78) + (9) - 2, .025) and -0.18784891957408173 = (24.71197974529063 - 29.354098440980067) / 24.71197974529063 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Linq.Tests.Perf_Enumerable.Range

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 486.6562259684169 > 452.0778635097359.
IsChangePoint: Marked as a change because one of 5/20/2022 10:18:01 PM, 5/25/2022 1:42:32 AM, 5/26/2022 5:29:00 PM, 6/2/2022 5:58:32 PM, 6/6/2022 10:12:27 PM, 6/17/2022 12:17:51 PM, 7/7/2022 7:02:29 PM, 7/13/2022 7:22:00 AM, 7/18/2022 2:17:16 AM falls between 7/8/2022 10:31:34 AM and 7/18/2022 2:17:16 AM.
IsRegressionStdDev: Marked as regression because -7.330515441769108 (T) = (0 -484.5610728537671) / Math.Sqrt((844.9484560029043 / (56)) + (1.6453164582133486 / (31))) is less than -1.988267907476882 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (31) - 2, .025) and -0.06254872100815734 = (456.0365687457705 - 484.5610728537671) / 456.0365687457705 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Linq.Tests.Perf_Enumerable.ToArray(input: IEnumerable)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 821.5784408492743 > 808.7701175205617.
IsChangePoint: Marked as a change because one of 5/31/2022 6:06:22 PM, 6/17/2022 12:17:51 PM, 6/20/2022 2:50:37 PM, 6/21/2022 5:13:43 PM, 7/13/2022 7:22:00 AM, 7/18/2022 2:17:16 AM falls between 7/8/2022 10:31:34 AM and 7/18/2022 2:17:16 AM.
IsRegressionStdDev: Marked as regression because -13.621194132784343 (T) = (0 -821.2265630031728) / Math.Sqrt((721.1285998974561 / (56)) + (7.868607568525319 / (31))) is less than -1.988267907476882 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (56) + (31) - 2, .025) and -0.06394746054424885 = (771.86759070141 - 821.2265630031728) / 771.86759070141 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS Windows 10.0.18362
Baseline b6932fd190e1c1159cee7fa6c48a1dded66e0fd7
Compare 8e40ec4b629abe52b92b6d2665d87fc884cc3033
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewCustomConverter - Duration of single invocation 28.24 μs 35.60 μs 1.26 0.06 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Payloads

Baseline
Compare

Histogram

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewCustomConverter


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 35.59964347008827 > 29.61307594105073.
IsChangePoint: Marked as a change because one of 6/22/2022 6:53:40 PM, 7/16/2022 8:09:48 AM, 7/18/2022 2:17:16 AM falls between 7/8/2022 10:31:34 AM and 7/18/2022 2:17:16 AM.
IsRegressionStdDev: Marked as regression because -20.139617901182813 (T) = (0 -33883.82076012451) / Math.Sqrt((916812.9638564995 / (78)) + (805523.9000989568 / (9))) is less than -1.988267907476882 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (78) + (9) - 2, .025) and -0.2332500917766698 = (27475.222573314477 - 33883.82076012451) / 27475.222573314477 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@AndyAyersMS
Copy link
Member

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Caused by dotnet/runtime#72228
Partially mitigated by dotnet/runtime#73497

The others are noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants