Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 7/6/2022 9:44:27 PM #6756

Closed
performanceautofiler bot opened this issue Jul 14, 2022 · 1 comment
Closed

[Perf] Changes at 7/6/2022 9:44:27 PM #6756

performanceautofiler bot opened this issue Jul 14, 2022 · 1 comment
Assignees
Labels
arch-arm64 branch-refs/heads/main kind-micro os-windows perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jul 14, 2022

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline d26ad8e4639974ebadf0cee835b956c01477e8e9
Compare 889404f6900ffb39bb33a66fa9e624191cab217c
Diff Diff

Regressions in System.Numerics.Tests.Perf_Matrix3x2

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CreateRotationWithCenterBenchmark - Duration of single invocation 24.74 ns 27.03 ns 1.09 0.30 False
CreateRotationBenchmark - Duration of single invocation 25.01 ns 27.74 ns 1.11 0.33 False

graph
graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Numerics.Tests.Perf_Matrix3x2*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Matrix3x2.CreateRotationWithCenterBenchmark


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 27.02602007944099 > 26.173622221518563.
IsChangePoint: Marked as a change because one of 4/27/2022 2:48:42 PM, 6/24/2022 5:32:42 PM, 7/1/2022 7:34:46 PM, 7/6/2022 5:19:04 PM, 7/14/2022 8:56:55 AM falls between 7/5/2022 7:51:46 PM and 7/14/2022 8:56:55 AM.
IsRegressionStdDev: Marked as regression because -9.355401021564077 (T) = (0 -29.594667875799782) / Math.Sqrt((1.2774643398016998 / (13)) + (3.8366116761677804 / (32))) is less than -2.016692199226234 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (32) - 2, .025) and -0.17322866827783778 = (25.224978451337442 - 29.594667875799782) / 25.224978451337442 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### System.Numerics.Tests.Perf_Matrix3x2.CreateRotationBenchmark

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 27.738263868678253 > 26.382193124698052.
IsChangePoint: Marked as a change because one of 6/24/2022 5:32:42 PM, 7/1/2022 7:34:46 PM, 7/6/2022 5:19:04 PM, 7/14/2022 8:56:55 AM falls between 7/5/2022 7:51:46 PM and 7/14/2022 8:56:55 AM.
IsRegressionStdDev: Marked as regression because -11.827357629030297 (T) = (0 -30.547985634173557) / Math.Sqrt((0.5411880354692792 / (13)) + (4.985873155572415 / (32))) is less than -2.016692199226234 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (32) - 2, .025) and -0.20778291118826697 = (25.292612895242225 - 30.547985634173557) / 25.292612895242225 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture arm64
OS Windows 10.0.19041
Baseline d26ad8e4639974ebadf0cee835b956c01477e8e9
Compare 889404f6900ffb39bb33a66fa9e624191cab217c
Diff Diff

Regressions in System.Collections.IndexerSet<String>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Array - Duration of single invocation 177.90 ns 364.89 ns 2.05 0.02 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.IndexerSet&lt;String&gt;*'

Payloads

Baseline
Compare

Histogram

System.Collections.IndexerSet<String>.Array(Size: 512)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 364.8920990566038 > 186.81754562409495.
IsChangePoint: Marked as a change because one of 6/15/2022 1:30:25 PM, 7/6/2022 5:19:04 PM, 7/14/2022 8:56:55 AM falls between 7/5/2022 7:51:46 PM and 7/14/2022 8:56:55 AM.
IsRegressionStdDev: Marked as regression because -227.1380860955839 (T) = (0 -363.78404913959145) / Math.Sqrt((6.888872378351081 / (13)) + (4.215102685720735 / (32))) is less than -2.016692199226234 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (13) + (32) - 2, .025) and -1.0319981798670719 = (179.02774359935168 - 363.78404913959145) / 179.02774359935168 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arm64 PGO Applied if there were any profile guided optimization updates in the observed interval. untriaged labels Jul 14, 2022
@EgorBo
Copy link
Member

EgorBo commented Jul 14, 2022

IndexerSet is dotnet/runtime#71659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 branch-refs/heads/main kind-micro os-windows perf-regression PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr
Projects
None yet
Development

No branches or pull requests

2 participants