Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 6/21/2022 11:38:18 AM #6335

Closed
performanceautofiler bot opened this issue Jun 23, 2022 · 1 comment
Closed

[Perf] Changes at 6/21/2022 11:38:18 AM #6335

performanceautofiler bot opened this issue Jun 23, 2022 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jun 23, 2022

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 715c71ae6af5775402e54d3b8ab6c4a888da3cb5
Compare d24bf0991d02ab07b93b71edfed8634de818060c
Diff Diff

Regressions in Microsoft.AspNetCore.Server.Kestrel.Performance.PipeThroughputBenchmark

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Parse_ParallelAsync - Duration of single invocation 1.23 μs 1.40 μs 1.13 0.47 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'Microsoft.AspNetCore.Server.Kestrel.Performance.PipeThroughputBenchmark*'

Payloads

Baseline
Compare

Histogram

Microsoft.AspNetCore.Server.Kestrel.Performance.PipeThroughputBenchmark.Parse_ParallelAsync(Length: 128, Chunks: 16)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.3996482136461321 > 1.2808492813617591.
IsChangePoint: Marked as a change because one of 5/9/2022 6:32:22 AM, 6/21/2022 3:41:14 AM, 6/23/2022 3:07:42 AM falls between 6/14/2022 10:05:19 AM and 6/23/2022 3:07:42 AM.
IsRegressionStdDev: Marked as regression because -3.563805949287773 (T) = (0 -1489.2043901314894) / Math.Sqrt((7008.797006878841 / (39)) + (36785.314562944324 / (7))) is less than -2.0153675744421933 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (39) + (7) - 2, .025) and -0.2142123340715675 = (1226.4777323895257 - 1489.2043901314894) / 1226.4777323895257 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@EgorBo
Copy link
Member

EgorBo commented Jul 14, 2022

The only suspect is dotnet/runtime#70921 (e.g. atomics are slower on "little" cores)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant