Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 6/20/2022 1:54:42 AM #6271

Closed
performanceautofiler bot opened this issue Jun 21, 2022 · 2 comments
Closed

[Perf] Changes at 6/20/2022 1:54:42 AM #6271

performanceautofiler bot opened this issue Jun 21, 2022 · 2 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jun 21, 2022

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 222d9e9e51cfbed5742bdba8d5007f6b7a524097
Compare 1ec5ba53884aa8704416acd73299919a3ef8533b
Diff Diff

Regressions in System.Buffers.Text.Tests.Base64Tests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
Base64Decode - Duration of single invocation 33.91 ns 763.99 ns 22.53 0.01 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Buffers.Text.Tests.Base64Tests*'

Payloads

Baseline
Compare

Histogram

System.Buffers.Text.Tests.Base64Tests.Base64Decode(NumberOfBytes: 1000)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 763.9880505646398 > 35.61522952859608.
IsChangePoint: Marked as a change because one of 6/19/2022 8:44:36 PM, 6/21/2022 6:07:15 AM falls between 6/12/2022 5:56:07 PM and 6/21/2022 6:07:15 AM.
IsRegressionStdDev: Marked as regression because -491.8535366750247 (T) = (0 -766.4744908018721) / Math.Sqrt((0.0023497222221480225 / (59)) + (19.96362347242179 / (9))) is less than -1.9965644189515832 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (59) + (9) - 2, .025) and -21.594504859702383 = (33.92304879266862 - 766.4744908018721) / 33.92304879266862 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@naricc
Copy link

naricc commented Jun 27, 2022

@a74nh I am seeing a large regression here, but I think it is because of your change to the benchmark here: dotnet/performance@281bdef. I don't see this as an issue to correct, since its just changing the benchmark. But I wanted to confirm with you.

@EgorBo
Copy link
Member

EgorBo commented Jun 27, 2022

@a74nh I am seeing a large regression here, but I think it is because of your change to the benchmark here: dotnet/performance@281bdef. I don't see this as an issue to correct, since its just changing the benchmark. But I wanted to confirm with you.

Yes, it's that, we also saw it in CoreCLR and closed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants