Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Changes at 1/10/2022 5:20:33 PM #2800

Closed
performanceautofiler bot opened this issue Jan 11, 2022 · 2 comments
Closed

[Perf] Changes at 1/10/2022 5:20:33 PM #2800

performanceautofiler bot opened this issue Jan 11, 2022 · 2 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jan 11, 2022

Run Information

Architecture x86
OS Windows 10.0.18362
Baseline 6c2758897402e88562fa9875c2c359ac6ef15b1f
Compare f9a1c78aafda683e46a1aa7208154e91f2fe167b
Diff Diff

Regressions in System.Collections.Tests.Perf_BitArray

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
BitArrayCopyToIntArray - Duration of single invocation 20.65 ns 26.09 ns 1.26 0.56 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Collections.Tests.Perf_BitArray*'

Payloads

Baseline
Compare

Histogram

System.Collections.Tests.Perf_BitArray.BitArrayCopyToIntArray(Size: 512)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 26.085400827058184 > 23.60279411972659.
IsChangePoint: Marked as a change because one of 1/10/2022 3:45:28 PM, 1/11/2022 6:33:01 AM falls between 1/2/2022 6:26:27 PM and 1/11/2022 6:33:01 AM.
IsRegressionStdDev: Marked as regression because -8.34583029912319 (T) = (0 -25.704588368215983) / Math.Sqrt((1.7245020495994894 / (55)) + (0.39918140519116574 / (3))) is less than -2.0032407188469383 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (55) + (3) - 2, .025) and -0.1516129194229966 = (22.320510594041437 - 25.704588368215983) / 22.320510594041437 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x86
OS Windows 10.0.18362
Baseline 6c2758897402e88562fa9875c2c359ac6ef15b1f
Compare f9a1c78aafda683e46a1aa7208154e91f2fe167b
Diff Diff

Regressions in System.Diagnostics.Perf_Activity

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
EnumerateActivityLinkTagsSmall - Duration of single invocation 70.04 ns 80.84 ns 1.15 0.10 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Diagnostics.Perf_Activity*'

Payloads

Baseline
Compare

Histogram

System.Diagnostics.Perf_Activity.EnumerateActivityLinkTagsSmall


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 80.83835542967655 > 73.43852045014012.
IsChangePoint: Marked as a change because one of 12/9/2021 12:47:15 PM, 12/27/2021 6:47:12 AM, 1/5/2022 11:42:27 AM, 1/10/2022 3:45:28 PM, 1/11/2022 6:33:01 AM falls between 1/2/2022 6:26:27 PM and 1/11/2022 6:33:01 AM.
IsRegressionStdDev: Marked as regression because -31.993210439769236 (T) = (0 -80.7303321776486) / Math.Sqrt((3.2727358748000253 / (55)) + (0.04854446601652936 / (3))) is less than -2.0032407188469383 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (55) + (3) - 2, .025) and -0.12236661961752864 = (71.92866463291581 - 80.7303321776486) / 71.92866463291581 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@kunalspathak
Copy link
Member

kunalspathak commented Jan 11, 2022

We think the "Regressions in System.Diagnostics.Perf_Activity" might be related to dotnet/runtime#63391. @janvorli , can you please double check?

@performanceautofiler
Copy link
Author

Closing because it's stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant