Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Windows/arm64: 7 Improvements on 8/28/2023 2:57:38 PM #21399

Closed
performanceautofiler bot opened this issue Sep 7, 2023 · 1 comment
Closed

[Perf] Windows/arm64: 7 Improvements on 8/28/2023 2:57:38 PM #21399

performanceautofiler bot opened this issue Sep 7, 2023 · 1 comment
Labels
arch-arm64 branch-refs/heads/main kind-micro os-windows perf-improvement PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Sep 7, 2023 •
edited
Loading

Run Information

Name Value
Architecture arm64
OS Windows 10.0.19041
Queue SurfaceWindows
Baseline 9eb9f9ffe8c03c8e28a16280be0a29a22bb351f7
Compare 41878765a826b5bbf54c00fd9b934bae337de650
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Improvements in System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Mariomkas

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
4.55 ms 3.49 ms 0.77 0.34 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Mariomkas*'

Payloads

Baseline
Compare

System.Text.RegularExpressions.Tests.Perf_Regex_Industry_Mariomkas.Count(Pattern: "[\w]+://[^/\\s?#]+[^\\s?#]+(?:\?[^\\s#])?(?:#[^\\s])?", Options: None)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 3.493261801242236 < 4.162207835937499.
IsChangePoint: Marked as a change because one of 6/7/2023 7:43:49 PM, 7/24/2023 8:03:13 PM, 8/8/2023 8:10:39 AM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 18.72137873573011 (T) = (0 -3503632.463862089) / Math.Sqrt((154507423987.51126 / (299)) + (61651616.73844396 / (12))) is greater than 1.9676708853560316 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (12) - 2, .975) and 0.10878949003891071 = (3931318.6107006967 - 3503632.463862089) / 3931318.6107006967 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture arm64
OS Windows 10.0.19041
Queue SurfaceWindows
Baseline 9eb9f9ffe8c03c8e28a16280be0a29a22bb351f7
Compare 41878765a826b5bbf54c00fd9b934bae337de650
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Improvements in Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
903.65 ns 791.75 ns 0.88 0.17 False
228.21 ns 195.50 ns 0.86 0.17 False
665.65 ns 549.82 ns 0.83 0.17 False
997.20 ns 813.84 ns 0.82 0.20 False
1.03 μs 864.34 ns 0.84 0.25 False

graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark*'

Payloads

Baseline
Compare

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_2

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 791.7526140279058 < 874.4188163589907.
IsChangePoint: Marked as a change because one of 7/28/2023 12:13:51 PM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 9.151666312081854 (T) = (0 -779.7971103824183) / Math.Sqrt((5092.302189097179 / (82)) + (544.9717036192112 / (12))) is greater than 1.986086316950818 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (82) + (12) - 2, .975) and 0.1084879321917256 = (874.690470875509 - 779.7971103824183) / 874.690470875509 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_0

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 195.4968375696139 < 217.21266510493984.
IsChangePoint: Marked as a change because one of 7/28/2023 12:13:51 PM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 6.543888852437496 (T) = (0 -198.69969279479415) / Math.Sqrt((431.0449960703052 / (82)) + (40.82015063061422 / (12))) is greater than 1.986086316950818 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (82) + (12) - 2, .975) and 0.08834578192911453 = (217.95510716251005 - 198.69969279479415) / 217.95510716251005 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_1

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 549.8196951205026 < 629.6230578224364.
IsChangePoint: Marked as a change because one of 7/28/2023 12:13:51 PM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 8.007236978536662 (T) = (0 -565.1982992607204) / Math.Sqrt((3222.581803139008 / (81)) + (206.32675512749472 / (12))) is greater than 1.9863771544181401 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (81) + (12) - 2, .975) and 0.09660837182364744 = (625.6403996145813 - 565.1982992607204) / 625.6403996145813 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_4

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 813.8376911590354 < 920.8351042174595.
IsChangePoint: Marked as a change because one of 7/28/2023 12:13:51 PM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 8.115488562308919 (T) = (0 -846.3238705226928) / Math.Sqrt((4632.919560270472 / (82)) + (696.3297762590363 / (12))) is greater than 1.986086316950818 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (82) + (12) - 2, .975) and 0.09306905325978149 = (933.1734390194031 - 846.3238705226928) / 933.1734390194031 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesBenchmark.CreateInstance_5

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 864.3448458789369 < 0.9799366409086976.
IsChangePoint: Marked as a change because one of 7/28/2023 12:13:51 PM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 9.029883664758056 (T) = (0 -891.1226796045022) / Math.Sqrt((6066.853104581635 / (81)) + (488.13178892459507 / (12))) is greater than 1.9863771544181401 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (81) + (12) - 2, .975) and 0.09823655519363274 = (988.200048179875 - 891.1226796045022) / 988.200048179875 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture arm64
OS Windows 10.0.19041
Queue SurfaceWindows
Baseline 9eb9f9ffe8c03c8e28a16280be0a29a22bb351f7
Compare 41878765a826b5bbf54c00fd9b934bae337de650
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Improvements in System.Reflection.Invoke

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
58.40 ns 48.83 ns 0.84 0.37 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Reflection.Invoke*'

Payloads

Baseline
Compare

System.Reflection.Invoke.Ctor4_int_string_struct_class

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 48.833828125 < 55.40640380743017.
IsChangePoint: Marked as a change because one of 7/14/2023 7:13:27 PM, 8/27/2023 2:42:29 PM, 9/5/2023 8:21:55 PM falls between 8/27/2023 2:42:29 PM and 9/5/2023 8:21:55 PM.
IsImprovementStdDev: Marked as improvement because 18.32609417898036 (T) = (0 -49.757815785781666) / Math.Sqrt((36.754561142255476 / (299)) + (10.676914144833697 / (12))) is greater than 1.9676708853560316 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (12) - 2, .975) and 0.2704091964036877 = (68.19962030841745 - 49.757815785781666) / 68.19962030841745 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-arm64 branch-refs/heads/main kind-micro os-windows perf-improvement PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr untriaged labels Sep 7, 2023
@performanceautofiler performanceautofiler bot mentioned this issue Sep 7, 2023
Closed
@EgorBo
Copy link
Member

EgorBo commented Sep 7, 2023

Static PGO

@EgorBo EgorBo closed this as completed Sep 7, 2023
@EgorBo EgorBo removed the untriaged label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-arm64 branch-refs/heads/main kind-micro os-windows perf-improvement PGO Applied if there were any profile guided optimization updates in the observed interval. runtime-coreclr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EgorBo