Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 1 Regression on 3/25/2023 7:34:08 PM #14540

Closed
performanceautofiler bot opened this issue Mar 28, 2023 · 2 comments
Closed

[Perf] Linux/x64: 1 Regression on 3/25/2023 7:34:08 PM #14540

performanceautofiler bot opened this issue Mar 28, 2023 · 2 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 28, 2023

Run Information

Name Value
Architecture x64
OS ubuntu 18.04
Queue TigerUbuntu
Baseline c22b79ae2d1b2a9ca73a42e246e3f3da02e631fe
Compare 95dbfc2f9cab66a9d5de834df5f25e8c3a71fc38
Diff Diff
Configs AOT:true, CompilationMode:wasm, RunKind:micro

Regressions in System.Threading.Tests.Perf_CancellationToken

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
CancelAfter - Duration of single invocation 331.22 ns 408.99 ns 1.23 0.07 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Threading.Tests.Perf_CancellationToken*'

Payloads

Baseline
Compare

Histogram

System.Threading.Tests.Perf_CancellationToken.CancelAfter


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 408.99354014549914 > 348.2298085098668.
IsChangePoint: Marked as a change because one of 2/15/2023 12:21:17 PM, 3/10/2023 8:06:53 PM, 3/25/2023 3:38:32 PM, 3/27/2023 3:21:55 PM falls between 3/18/2023 7:37:20 PM and 3/27/2023 3:21:55 PM.
IsRegressionStdDev: Marked as regression because -18.545266974833844 (T) = (0 -413.4086080087377) / Math.Sqrt((46.556476606020865 / (53)) + (150.64161098946664 / (8))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (53) + (8) - 2, .025) and -0.24867430840284802 = (331.07801227809324 - 413.4086080087377) / 331.07801227809324 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@radekdoulik
Copy link
Member

@tarekgh looks like dotnet/runtime#83604

@tarekgh
Copy link
Member

tarekgh commented Mar 29, 2023

This is duplicate to #14530. @radekdoulik please close it.

@tarekgh tarekgh removed their assignment Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants