Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 4 Regressions on 1/20/2023 12:33:18 PM #12047

Closed
performanceautofiler bot opened this issue Jan 24, 2023 · 0 comments
Closed

[Perf] Linux/x64: 4 Regressions on 1/20/2023 12:33:18 PM #12047

performanceautofiler bot opened this issue Jan 24, 2023 · 0 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Jan 24, 2023

Run Information

Architecture x64
OS ubuntu 18.04
Baseline b5fb7d002acbf729151da9d9918a93c8261d1e95
Compare 225ae771d66dd2732fef7d8ad3a5f2b7b00f8c05
Diff Diff

Regressions in Microsoft.Extensions.Logging.FormattingOverhead

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
FourArguments_DefineMessage - Duration of single invocation 2.93 μs 4.21 μs 1.43 0.01 False
TwoArguments - Duration of single invocation 2.07 μs 2.81 μs 1.36 0.05 False
TwoArguments_DefineMessage - Duration of single invocation 1.70 μs 2.46 μs 1.45 0.03 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Microsoft.Extensions.Logging.FormattingOverhead*'

Payloads

Baseline
Compare

Histogram

Microsoft.Extensions.Logging.FormattingOverhead.FourArguments_DefineMessage


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.20701456207262 > 2.7029704616426824.
IsChangePoint: Marked as a change because one of 1/20/2023 8:02:54 AM, 1/24/2023 10:20:22 AM falls between 1/15/2023 6:48:05 PM and 1/24/2023 10:20:22 AM.
IsRegressionStdDev: Marked as regression because -56.05578834641782 (T) = (0 -4270.243574751498) / Math.Sqrt((27527.023931297084 / (46)) + (1506.400862393005 / (23))) is less than -1.9960083540247138 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (46) + (23) - 2, .025) and -0.5111168987060676 = (2825.885660075672 - 4270.243574751498) / 2825.885660075672 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### Microsoft.Extensions.Logging.FormattingOverhead.TwoArguments

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.8058833071325906 > 1.920628045657991.
IsChangePoint: Marked as a change because one of 1/20/2023 8:02:54 AM, 1/24/2023 10:20:22 AM falls between 1/15/2023 6:48:05 PM and 1/24/2023 10:20:22 AM.
IsRegressionStdDev: Marked as regression because -41.94631947644872 (T) = (0 -2852.1622336120026) / Math.Sqrt((11379.947064886324 / (46)) + (3617.5547591131517 / (23))) is less than -1.9960083540247138 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (46) + (23) - 2, .025) and -0.42015377829917866 = (2008.3474601094558 - 2852.1622336120026) / 2008.3474601094558 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### Microsoft.Extensions.Logging.FormattingOverhead.TwoArguments_DefineMessage

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.461200092927072 > 1.5826977781497902.
IsChangePoint: Marked as a change because one of 1/20/2023 8:02:54 AM, 1/24/2023 10:20:22 AM falls between 1/15/2023 6:48:05 PM and 1/24/2023 10:20:22 AM.
IsRegressionStdDev: Marked as regression because -56.831070393132116 (T) = (0 -2494.3881439099805) / Math.Sqrt((9557.144269033077 / (46)) + (375.69572449838563 / (23))) is less than -1.9960083540247138 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (46) + (23) - 2, .025) and -0.5176080066826376 = (1643.6313810458219 - 2494.3881439099805) / 1643.6313810458219 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

### Run Information
Architecture x64
OS ubuntu 18.04
Baseline b5fb7d002acbf729151da9d9918a93c8261d1e95
Compare 225ae771d66dd2732fef7d8ad3a5f2b7b00f8c05
Diff Diff

Regressions in Microsoft.Extensions.Logging.Formatting

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
TwoArguments - Duration of single invocation 1.71 μs 2.45 μs 1.43 0.04 False

Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Microsoft.Extensions.Logging.Formatting*'

Payloads

Baseline
Compare

Histogram

Microsoft.Extensions.Logging.Formatting.TwoArguments


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 2.4470034695494682 > 1.5873355362715538.
IsChangePoint: Marked as a change because one of 1/20/2023 8:02:54 AM, 1/24/2023 10:20:22 AM falls between 1/15/2023 6:48:05 PM and 1/24/2023 10:20:22 AM.
IsRegressionStdDev: Marked as regression because -54.9877443842182 (T) = (0 -2482.889810032086) / Math.Sqrt((8837.532398306907 / (46)) + (969.12196096189 / (23))) is less than -1.9960083540247138 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (46) + (23) - 2, .025) and -0.5127773623900499 = (1641.2790617843114 - 2482.889810032086) / 1641.2790617843114 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant