-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orleans client fails to load contract dll randomly #9214
Comments
I can reproduce this. Thank you for putting it together. This is a limitation of heterogenous clusters currently. The workaround is to add all contract assemblies to all silos (all gateways, which is all silos in this case). The limitation is at the RPC layer. I have a branch to fix this, but it's not in a mergeable state just yet. The reason that it works sometimes even without this is that the client might send the request to a compatible gateway. cc @benjaminpetit: we could change client routing to pick compatible gateways while we prepare the true fix. |
Thanks for quick response. To clarify, I only need to reference the contract, not the grain implementation? |
Yes, that's correct |
Had some issues with the orleansdashboard, my guess is that it is related. |
I actually have the issue from time to time even after adding the references. I have added a reference to all contracts projects to all my silos and the api. Some times it does work, then all of a sudden it fails. The changes can be seen in this PR: https://github.com/mastoj/monostore/pull/1/files |
@ReubenBond , do you maybe know why I still see it. I find it very confusing because after starting up the cluster it can fail for a couple of requests, but when changing the id of the cart I try to create a couple of times it start working. |
I have a small example/POC I'm working on where I want to demonstrate how orleans can make life easier and also more robust.
If you want to go straight to the code it is here: https://github.com/mastoj/monostore/tree/random-error
The setup is that I have an API as a Orleans Client, and then I have two different workers as silos, one for cart and one for product. I also have an API project for cart and product that the main API project references to keep the cart api definitions close to the rest of the cart implementation. The cart/product API as then referencing their own contract folder which defines the contracts for the API and grains.
So basically I have the below for cart (same for product):
When I make a call to the API to create a cart, https://github.com/mastoj/monostore/blob/a9abe53968a5ee17acc929c86a36ea29e8fc7cfd/src/cart/requests/requests.http#L5, it fails randomly with the exception
The exception is thrown in the API project, so the request never reaches the silo.
Everything is set up with Aspire, but I don't think that should impact how dlls are loaded.
The text was updated successfully, but these errors were encountered: