Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming UnsubscribeAsync timeout on deactivate #6161

Open
stephenlautier opened this issue Dec 5, 2019 · 1 comment
Open

Streaming UnsubscribeAsync timeout on deactivate #6161

stephenlautier opened this issue Dec 5, 2019 · 1 comment
Assignees
Labels
area-streaming Category for Orleans streaming issues enhancement Needs: investigation 🔍 Issue that needs investigation
Milestone

Comments

@stephenlautier
Copy link

stephenlautier commented Dec 5, 2019

We have been experiencing several timeouts in SMS and now im trying to do some changes to help it improve (or try understand from where); and now it seems that when we call UnsubscribeAsync there's a great chance that it hangs, currently its on OnDeactivateAsync but I will test even further

This is the error thrown after timeout's

[14:47:39 ERR] [Orleans.Runtime.Catalog] Error calling grain's OnDeactivateAsync() method - Grain type = SignalR.Orleans.Groups.GroupGrain Activation = [Activation: S127.0.0.1:11111:313249616*grn/B47CEF79/00000000+HeroHub:hero:all@40771ea9 #GrainType=SignalR.Orleans.Groups.GroupGrain Placement=RandomPlacement State=Deactivating]
System.Threading.Tasks.TaskCanceledException: A task was canceled.
   at async Task Orleans.OrleansTaskExtentions.MakeCancellable(Task task, CancellationToken cancellationToken) in D:/build/agent/_work/25/s/src/Orleans.Core/Async/TaskExtensions.cs:line 346
   at async Task<ActivationData> Orleans.Runtime.Catalog.CallGrainDeactivateAndCleanupStreams(ActivationData activation, CancellationToken ct) in D:/build/agent/_work/25/s/src/Orleans.Runtime/Catalog/Catalog.cs:line 1183

Basically its hanging in the await of the breakpoint - i had tried several different options like manual loops instead of Select, or so but still same issue
image

It should work doing UnsubscribeAsync on OnDeactivateAsync

Using Orleans: 2.3.5 (tried also with 2.4.4)
Running on Windows 10 (local)

NOTE: all code is open source but i have a branch on SignalR.Orleans, and the issue is inside Signalr.Orleans, and we have a "sample" app which consumes it - if really needed i can write a small guide exactly how to setup

update:

  • just another note it was being deactivated via the DeactivateOnIdle
  • now changed with timer on activation to perform cleanup via interval and it doesnt seem to be timing out (so far)
@ghost
Copy link

ghost commented Jul 28, 2022

We've moved this issue to the Backlog. This means that it is not going to be worked on for the coming release. We review items in the backlog at the end of each milestone/release and depending on the team's priority we may reconsider this issue for the following milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-streaming Category for Orleans streaming issues enhancement Needs: investigation 🔍 Issue that needs investigation
Projects
None yet
Development

No branches or pull requests

4 participants