Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Expander.TryExecuteWellKnownFunction #9975

Open
YuliiaKovalova opened this issue Apr 4, 2024 · 0 comments · May be fixed by #11089
Open

Refactor Expander.TryExecuteWellKnownFunction #9975

YuliiaKovalova opened this issue Apr 4, 2024 · 0 comments · May be fixed by #11089
Assignees
@SimaTian
Labels
needs-triage Have yet to determine what bucket this goes in. Priority:3 Work that is nice to have Refactoring triaged

Comments

@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented Apr 4, 2024 •
edited
Loading

Refactor candidate

I have stumbled upon the piece of code and suggest to rethink it:

msbuild/src/Build/Evaluation/Expander.cs

Line 3643 in 28f488a

private bool TryExecuteWellKnownFunction(out object returnVal, object objectInstance, object[] args)

It contains code duplications and it's current size poorly manageable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimaTian SimaTian

Labels
needs-triage Have yet to determine what bucket this goes in. Priority:3 Work that is nice to have Refactoring triaged
Projects
None yet
Milestone
No milestone
4 participants
@baronfel @SimaTian @maridematte @YuliiaKovalova