Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildXL nuget repo deletion breaks building older releases #10917

Closed
omajid opened this issue Oct 31, 2024 · 4 comments
Closed

BuildXL nuget repo deletion breaks building older releases #10917

omajid opened this issue Oct 31, 2024 · 4 comments

Comments

@omajid
Copy link
Member

omajid commented Oct 31, 2024

The BuildXL nuget repo was recently deleted. This broke source-build (eg dotnet/source-build#4634) which was easily fixed.

However, this also broke online builds of older versions of .NET, which all require fixing some way or the other.

For example:

  • I wanted to rebuild 9.0 RC 1 with a custom fix to re-bootstrap 9.0 RC 2. But RC 1 is broken due to missing BuildXL repo and can't be fixed (due to being a point-in-time release)
  • Someone on my team is trying to test an older commit of .NET 8 - 8.0 RC 1 specifically - to see if it reproduces a bug. But the 8.0 build is broken because BuildXL is removed.

I know that, in general, expecting older releases to build out of the box is not realistic. Many bugs, tooling support and compatibility fixes are missing in older releases. However, this change accidentally breaks all older releases.

@MichaelSimons
Copy link
Member

Transferring to msbuild as this was caused by #10765

@MichaelSimons MichaelSimons transferred this issue from dotnet/source-build Oct 31, 2024
@rainersigwald
Copy link
Member

I don't think there's anything that we can do to fix this. Older builds will have to patch out that feed.

@YuliiaKovalova
Copy link
Member

Hi @omajid ,

We have backported it to the older release branches. For other changes you would need to cherry pick this commit d0a797e and use version from here 0a3683c.

@omajid
Copy link
Member Author

omajid commented Nov 5, 2024

Thanks. I have a few workarounds for this now.

I want to raise awareness of how deleting a nuget repo can have a broader impact than just the new releases.

@YuliiaKovalova YuliiaKovalova closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants