Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwipeView erroneusly triggers SelectionChangedCommand in CollectionView on swiping gesture. (Was not the case with Xamarin.Forms) #22711

Open
inimirpaz opened this issue May 29, 2024 · 4 comments
Labels
area-controls-swipeview SwipeView migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@inimirpaz
Copy link

Description

Hello, I have found a migration issue when using SwipeViews nested in a CollectionView. The SelectionChangedCommand is fired during the swiping operations. This was not the intended behavior with Xamarin.Forms . In fact, the command is executed both on the opening gesture and when the user closes the SwipeView (either by swiping it back or by tapping on the row). The command should not be invoked in none of those scenarios.

Repro provides both the .NET MAUI and the Xamarin.Forms solutions.

Steps to Reproduce

No response

Link to public reproduction project repository

https://github.com/inimirpaz/maui_issues/tree/swipeview_tap_issue

Version with bug

8.0.40 SR5

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

@inimirpaz inimirpaz added the t/bug Something isn't working label May 29, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@Quaybe
Copy link

Quaybe commented May 29, 2024

That second item looks to be the same issue as yours (I'm having this issue too)

@ninachen03 ninachen03 added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert labels May 30, 2024
@ninachen03
Copy link

Verified this issue with Visual Studio 17.11.0 Preview 1.0 ( 8.0.40 & 8.0.21& 8.0.3 ) Can repro it, Xamarin.Forms works fine

@tbambuch
Copy link

tbambuch commented Jun 4, 2024

this is (on Android) caused by MauiSwipeView.PropagateParentTouch() function, which fires itemContentView?.CallOnClick every time. Previously, in XF, there used to be a check for ((ISwipeViewController)Element).IsOpen which is missing now for unknown reason

@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 7, 2024
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 3, 2024
@samhouts samhouts added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-swipeview SwipeView migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants