Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CpuMath Enhancement: Use FusedMultiplyAdd in hardware intrinsics APIs #832

Closed
briancylui opened this issue Sep 5, 2018 · 1 comment
Closed

CpuMath Enhancement: Use FusedMultiplyAdd in hardware intrinsics APIs #832

briancylui opened this issue Sep 5, 2018 · 1 comment
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@briancylui
Copy link
Contributor

Style changes needed to solve part of #823

Details

  • In src\Microsoft.ML.CpuMath\SseIntrinsics.cs, Use FusedMultiplyAdd to replace srcVector = Sse.Multiply(srcVector, scaleVector); in AddScaleU. It would be part of any AVX related code-work.
@briancylui briancylui changed the title Use FusedMultiplyAdd in hardware intrinsics APIs CpuMath Enhancement: Use FusedMultiplyAdd in hardware intrinsics APIs Sep 6, 2018
@danmoseley danmoseley added the up-for-grabs A good issue to fix if you are trying to contribute to the project label Sep 6, 2018
@helloguo
Copy link

@eerhardt @danmosemsft
Is anyone doing this work? if not, please assign it to me :)

@helloguo helloguo mentioned this issue Oct 18, 2018
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danmoseley @briancylui @helloguo