Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotReload fails if DotNetTool resolves to a path with a space #31

Closed
tannergooding opened this issue May 21, 2021 · 1 comment
Closed

Comments

@tannergooding
Copy link
Member

As per dotnet/runtime#53091, building the dotnet/runtime repo can eventually fail with:

'C:\Program' is not recognized as an internal or external command,
  operable program or batch file.
C:\Users\tagoo\.nuget\packages\microsoft.dotnet.hotreload.utils.generator.buildtool\1.0.1-alpha.0.21267.1\build\Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.targets(56,5): error MSB3073: The command "C:\Program Files\dotnet\dotnet.exe C:\Users\tagoo\.nuget\packages\microsoft.dotnet.hotreload.utils.generator.buildtool\1.0.1-alpha.0.21267.1\build\\..\tools\net6.0\Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.dll -msbuild:C:\Users\tagoo\Source\repos\runtime\src\libraries\System.Runtime.Loader\tests\ApplyUpdate\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1.csproj -script:C:\Users\tagoo\Source\repos\runtime\src\libraries\System.Runtime.Loader\tests\ApplyUpdate\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1\deltascript.json -p:Configuration=Release" exited with code 9009. [C:\Users\tagoo\Source\repos\runtime\src\libraries\System.Runtime.Loader\tests\ApplyUpdate\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1\System.Reflection.Metadata.ApplyUpdate.Test.MethodBody1.csproj]

This looks to be failing because the targets file runs <Exec Command="$(_HotReloadDeltaGeneratorCommand) $(_HotReloadDeltaGeneratorArgs)" />, where <_HotReloadDeltaGeneratorCommand>$(DotNetTool) $(_HotReloadDeltaGeneratorPath)</_HotReloadDeltaGeneratorCommand>.

I'd expect that DotNetTool should be properly quoted for this to work.

@tannergooding
Copy link
Member Author

This was fixed in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant