inconsistent embed options with Fsc and Csc tasks

[ctaggart]

The option names are inconsistnent and Fsc only worked when full paths were passed in.

$(MSBuildProgramFiles32)\Microsoft SDKs\F#\4.1\Framework\v4.0\Microsoft.FSharp.Targets
C:\Program Files (x86)\Microsoft SDKs\F#\4.1\Framework\v4.0\Microsoft.FSharp.Targets

Embed="$(Embed)"

C:\Program Files\dotnet\sdk\1.0.0\Microsoft.CSharp.Core.targets

EmbeddedFiles="@(EmbeddedFiles)"

I worked around both issues with:

<Project>
  <PropertyGroup>
    <BuildDependsOn>EmbedPaketFiles;$(BuildDependsOn)</BuildDependsOn>
  </PropertyGroup>
  <Target Name="EmbedPaketFiles">
    <ItemGroup>
      <EmbeddedFiles Include="$([System.IO.Path]::GetFullPath('%(Compile.Identity)'))"
        Condition="$([System.String]::Copy('%(Identity)').Contains('paket-files'))" />
    </ItemGroup>
    <CreateProperty Value="@(EmbeddedFiles)">  
      <Output TaskParameter="Value" PropertyName="embed" />  
    </CreateProperty>
  </Target>
</Project>

I would like it if the Fsc tasks matched what Csc supports.

[ctaggart]

I think this ship has sailed. As part of SourceLink 2.1.1, I released SourceLink.Embed.AllSourceFiles that works for both C# & F# as well as SourceLink.Embed.PaketFiles that is a subset.
https://github.com/ctaggart/SourceLink/releases/tag/2.1.1

Given that the Visual Studio 2017 debugger doesn't actually work with embedded source files yet, it still may be safe to change. https://github.com/ctaggart/sourcelink#known-issues