Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - Signature conformance of .fsi nullness and infered nullness from .fs #18185

Open
1 of 7 tasks
T-Gro opened this issue Dec 30, 2024 · 0 comments · May be fixed by #18186
Open
1 of 7 tasks

Nullness issue - Signature conformance of .fsi nullness and infered nullness from .fs #18185

T-Gro opened this issue Dec 30, 2024 · 0 comments · May be fixed by #18186
Assignees
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage
Milestone

Comments

@T-Gro
Copy link
Member

T-Gro commented Dec 30, 2024

Issue description

A nullness warning is missing when an .fsi specifies strict non-nullable type and implementation uses type inference to the nullable version of the same type

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

NET 9

Reproducible code snippet and actual behavior

Signature

val iRejectNulls: string -> string

Implementation

let iRejectNulls (x:_|null) = 
    match x with
    | null -> "null"
    | s -> String.length s |> string

Possible workarounds

Do not use .fsi

@T-Gro T-Gro added Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage labels Dec 30, 2024
@T-Gro T-Gro self-assigned this Dec 30, 2024
@github-actions github-actions bot added this to the Backlog milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage
Projects
Status: New
1 participant