Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build project referencing self-built FCS and FSharp.Core package #17800

Open
auduchinok opened this issue Sep 26, 2024 · 4 comments
Open

Comments

@auduchinok
Copy link
Member

auduchinok commented Sep 26, 2024

I'm trying to upgrade FCS in the Rider plugin. However, there are issues with building.

Due to #17698 FSharp.Core is no longer referenced as a package, and is referenced as a project instead. We build FCS ourselves but I don't know a way to build FSharp.Core properly, so its assembly strong name matches the one published by Microsoft. Is there something that I miss and it's possible? If not, then we need to find a way to use FSharp.Core package when building FCS.

As a workaround I've tried to use both 8.0.400 and the current preview FSharp.Core versions, but I'm getting an error during build:

Error CS0115 :
  'FsShim.OpenFileForReadShim(string, FSharpOption<bool>, FSharpOption<bool>)':
  no suitable method found to override

It seems there may be some issue in the code generated by F# compiler?
Here's a minimized repro:
FcsFileSystemShimOverride.zip

@vzarytovskii
Copy link
Member

As a workaround I've tried to use both 8.0.400 and the current preview FSharp.Core versions,

I don't think this will ever work.

I think the only way now is to wait for rc2, update it here, and it should allow using package version of fsharp.core. Or try downgrading to p6 and use 8.0.400

@auduchinok
Copy link
Member Author

I think the only way now is to wait for rc2, update it here, and it should allow using package version of fsharp.core.

Thanks! Do you know if there're any estimates when it's going to be available?

@KevinRansom
Copy link
Member

@auduchinok --- working on it now, How did I not know nested generic types required this, although it makes perfect sense to me now.

image

@vzarytovskii
Copy link
Member

I think the only way now is to wait for rc2, update it here, and it should allow using package version of fsharp.core.

Thanks! Do you know if there're any estimates when it's going to be available?

Unfortunately no, it's already frozen for a week, so I expect it to be available soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New
Development

No branches or pull requests

4 participants