Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependencyInjection and IAsyncDisposable #1751

Closed
seesharper opened this issue May 26, 2019 · 2 comments
Closed

DependencyInjection and IAsyncDisposable #1751

seesharper opened this issue May 26, 2019 · 2 comments
Milestone

Comments

@seesharper
Copy link

Hi. I am the author of LightInject and was wondering if there is something we should be aware of with regards to AsyncDisposable. I see that tests has been added here.

https://github.com/aspnet/Extensions/blob/master/src/DependencyInjection/DI/test/ServiceProviderContainerTests.AsyncDisposable.cs

Although there seems to be no sign of AsyncDisposable in the specification tests we as adapter developers use to confirm compatibility?

@davidfowl. Anything external DI developers needs to know about? 😀

@seesharper seesharper changed the title DependencyInjection and AsyncDisposable DependencyInjection and IAsyncDisposable May 26, 2019
@pakrym
Copy link

pakrym commented Jun 3, 2019

AsyncDisposable implementation is optional, hosting would call DisposeAsync if the container implements IAsyncDisposable or Dispose if it only implements IDisposable. That's why specification doesn't require it.

@analogrelay analogrelay added this to the Discussions milestone Jun 17, 2019
@analogrelay
Copy link

Closing inactive discussion thread.


Note: Inactive closed issues are locked after 30 days since we don't triage closed issues and new comments tend to be lost. Feel free to post a new issue if this issue is locked and you have further questions/discussions. See our issue management policies for more details.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants