Skip to content

Commit

Permalink
Set AssemblyVersion and prevent hosting tests from rebuilding the pro…
Browse files Browse the repository at this point in the history
…duct code (#1791)
  • Loading branch information
natemcmaster authored Jun 4, 2019
1 parent e4e6ac0 commit 54d51a3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Hosting/IntegrationTesting/src/ApplicationPublisher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ public virtual Task<PublishedApplication> Publish(DeploymentParameters deploymen
+ $" --output \"{publishDirectory.FullName}\""
+ $" --framework {deploymentParameters.TargetFramework}"
+ $" --configuration {deploymentParameters.Configuration}"
// avoids triggering builds of dependencies of the test app which could cause issues like https://github.com/dotnet/arcade/issues/2941
+ $" --no-dependencies"
+ $" /p:TargetArchitecture={deploymentParameters.RuntimeArchitecture}"
+ " --no-restore";

Expand Down
7 changes: 7 additions & 0 deletions version.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
<PatchVersion>0</PatchVersion>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<PreReleaseVersionLabel>preview6</PreReleaseVersionLabel>
<AssemblyVersion Condition="'$(IsReferenceAssemblyProject)' != 'true'">$(VersionPrefix).0</AssemblyVersion>
<!--
We do not support changing reference assemblies in a patch. This ignores
the patch version number to ensure assembly version of ref assemblies stays constant
throughout major.minor.
-->
<AssemblyVersion Condition="'$(IsReferenceAssemblyProject)' == 'true'">$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down

0 comments on commit 54d51a3

Please sign in to comment.