[release/9.0] Add explicit casts for generated null in method calls. #34523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Aug 24, 2024
It might make compilation marginally faster in general as there's less guesswork. And readability isn't really a goal here. |
AndriySvyryd
force-pushed
the
Issue34515
branch
from
3ab2fe9
to
a8b7cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34515
Description
When expressions generated as part of the compiled model contain a method call with a
nullargument they might fail to compile if there are ambiguous overloads. This is fixed by generating an explicit cast.Customer impact
The generated compiled model doesn't compile and needs to be fixed manually after every time it's regenerated.
How found
Reported by a customer.
Regression
No.
Testing
Tests added.
Risk
Low. This code is only invoked at design-time.