Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better reporting for query cache hits and misses for OTEL. #34267

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Better reporting for query cache hits and misses for OTEL. #34267

merged 1 commit into from
Jul 23, 2024

Conversation

cincuranet
Copy link
Contributor

Fixes #33959

@cincuranet cincuranet requested a review from roji July 22, 2024 11:40
@cincuranet cincuranet mentioned this pull request Jul 22, 2024
Merged
roji
roji approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for those that little in that got added there

@cincuranet
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cincuranet cincuranet merged commit a673d81 into dotnet:main Jul 23, 2024
7 checks passed
@cincuranet cincuranet deleted the otel-hits-misses branch July 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better reporting for compiled_query_cache_hit_rate metric
2 participants
@cincuranet @roji