-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Data.Sqlite.Core issue with multiple Blob colums #32770
Conversation
francopettinari
commented
Jan 10, 2024
- [x ] I've read the guidelines for contributing and seen the walkthrough
- [ x] I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
- [x ] The code builds and tests pass locally (also verified by our automated build checks)
- Commit messages follow this format:
- [x ] Tests for the changes have been added (for bug fixes / features)
- [x ] Code follows the same patterns and style as existing code in this repo
@dotnet-policy-service agree |
@dotnet-policy-service agree |
@francopettinari Where is the test? |
SqliteDataReaderTest.GetBytes_works_streaming_join() |
internal class SqliteDataRecord : SqliteValueReader, IDisposable | ||
{ | ||
internal class RowIdInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use a value tuple for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was only for readability
@francopettinari Please add a test that fails before this change but passes after it. |
I already added a test. |
@francopettinari The PR diff only shows changes to one file. |
sorry, now pushed. |
@ajcvickers I committed the test case. Should I do something else or comment/reply in onother way? |
@francopettinari No, I just need to get to reviewing it, but, of course, I have other things that need doing as well. |
break; | ||
} | ||
} | ||
} | ||
|
||
Debug.Assert(_rowidOrdinal.HasValue); | ||
//Debug.Assert(rowIdForOrdinal!=null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-add Assert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puppy error, sorry. Commented for initial checks and later committed. Not intentional. Sorry again!
I readded, relaunched the tests and finally committed.
Thanks for the contribution! |