Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolding fix for nvarchar(4000) (port to patch) #9963

Closed
ajcvickers opened this issue Oct 4, 2017 · 7 comments
Closed

Scaffolding fix for nvarchar(4000) (port to patch) #9963

ajcvickers opened this issue Oct 4, 2017 · 7 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@ajcvickers
Copy link
Member

See full details here: #9188

Note: this still needs to be approved for patch, so it's not 100% for sure in 2.0.1 yet.

@ajcvickers ajcvickers added this to the 2.0.1 milestone Oct 4, 2017
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 6, 2017
@Eilon
Copy link
Member

Eilon commented Oct 9, 2017

This patch bug is approved for the 2.0.x patch. Please send a PR to the rel/2.0.1 branch and get it reviewed and merged.

@Eilon
Copy link
Member

Eilon commented Oct 23, 2017

Hi, we have a public test feed that you can use to try out the ASP.NET/EF Core 2.0.3 patch!

To try out the pre-release patch, please refer to the following guide:

We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.

Thanks,
Eilon

@ksahota
Copy link

ksahota commented Oct 27, 2017

I have tried the ASP.NET/EF Core 2.0.3 patch and the scaffolding issue is still there.
image

image

@smitpatel
Copy link
Contributor

@ksahota - Did you re-scaffold database or upgraded package in already scaffolded code?

@ksahota
Copy link

ksahota commented Oct 27, 2017

@smitpatel , Upgraded package in already scafolded code .

@smitpatel
Copy link
Contributor

This fix does not solve that issue. You manually have to edit generated file in existing files. Or you can delete scaffolded code and re-generate them. This fix stops producing incorrect code.

@ksahota
Copy link

ksahota commented Oct 27, 2017

Seems to be working. Thanks @smitpatel

@divega divega changed the title Port scaffolding fix for nvarchar(4000) to 2.0.1 Scaffolding fix for nvarchar(4000) (port to patch) Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

4 participants