Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlterColumnOperation_with_identity_legacy fails consistency after commit to support resetting Identity #32946

Closed
ajcvickers opened this issue Jan 28, 2024 · 1 comment · Fixed by #32949
Closed

AlterColumnOperation_with_identity_legacy fails consistency after commit to support resetting Identity #32946

ajcvickers opened this issue Jan 28, 2024 · 1 comment · Fixed by #32949
Assignees
@roji
Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
9.0.0

Comments

@ajcvickers
Copy link
Member 

Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGeneratorTest.AlterColumnOperation_with_identity_legacy
System.Diagnostics.UnreachableException : Check.DebugAssert failed: Unsupported column change to identity
   at Microsoft.EntityFrameworkCore.Utilities.Check.DebugAssert(Boolean condition, String message) in D:\code\efcore\src\Shared\Check.cs:line 115
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(AlterColumnOperation operation, IModel model, MigrationCommandListBuilder builder) in D:\code\efcore\src\EFCore.SqlServer\Migrations\SqlServerMigrationsSqlGenerator.cs:line 327
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.<>c.<.cctor>b__83_4(MigrationsSqlGenerator g, MigrationOperation o, IModel m, MigrationCommandListBuilder b) in D:\code\efcore\src\EFCore.Relational\Migrations\MigrationsSqlGenerator.cs:line 39
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder) in D:\code\efcore\src\EFCore.Relational\Migrations\MigrationsSqlGenerator.cs:line 159
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(MigrationOperation operation, IModel model, MigrationCommandListBuilder builder) in D:\code\efcore\src\EFCore.SqlServer\Migrations\SqlServerMigrationsSqlGenerator.cs:line 97
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model, MigrationsSqlGenerationOptions options) in D:\code\efcore\src\EFCore.Relational\Migrations\MigrationsSqlGenerator.cs:line 124
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGenerator.Generate(IReadOnlyList`1 operations, IModel model, MigrationsSqlGenerationOptions options) in D:\code\efcore\src\EFCore.SqlServer\Migrations\SqlServerMigrationsSqlGenerator.cs:line 65
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGeneratorTestBase.Generate(Action`1 buildAction, MigrationOperation[] operation, MigrationsSqlGenerationOptions options) in D:\code\efcore\test\EFCore.Relational.Specification.Tests\Migrations\MigrationsSqlGeneratorTestBase.cs:line 803
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGeneratorTestBase.Generate(Action`1 buildAction, MigrationOperation[] operation) in D:\code\efcore\test\EFCore.Relational.Specification.Tests\Migrations\MigrationsSqlGeneratorTestBase.cs:line 783
   at Microsoft.EntityFrameworkCore.Migrations.MigrationsSqlGeneratorTestBase.Generate(MigrationOperation[] operation) in D:\code\efcore\test\EFCore.Relational.Specification.Tests\Migrations\MigrationsSqlGeneratorTestBase.cs:line 769
   at Microsoft.EntityFrameworkCore.Migrations.SqlServerMigrationsSqlGeneratorTest.AlterColumnOperation_with_identity_legacy() in D:\code\efcore\test\EFCore.SqlServer.FunctionalTests\Migrations\SqlServerMigrationsSqlGeneratorTest.cs:line 245
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
@ajcvickers
Copy link
Member Author

/cc @roji Looks like your merge from yesterday broke the tests.

roji added a commit to roji/efcore that referenced this issue Jan 29, 2024
@roji
Fix failing test related to SQL Server identity reseeding
dcd4698 
Fixes dotnet#32946
@roji roji mentioned this issue Jan 29, 2024
Merged
@roji roji added type-bug area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Jan 29, 2024
ajcvickers pushed a commit that referenced this issue Jan 29, 2024
@roji
Fix failing test related to SQL Server identity reseeding (#32949)
dc80beb 
Fixes #32946
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-preview1, 9.0.0-preview2 Jan 29, 2024
@roji roji modified the milestones: 9.0.0-preview2, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-migrations area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Fix failing test related to SQL Server identity reseeding roji/efcore
2 participants
@ajcvickers @roji