Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFCore 7 - Some JSON GIT tests removed from EFCore 7? #30899

Closed
shvmgpt116 opened this issue May 16, 2023 · 1 comment
Closed

EFCore 7 - Some JSON GIT tests removed from EFCore 7? #30899

shvmgpt116 opened this issue May 16, 2023 · 1 comment
Labels
closed-no-further-action The issue is closed and no further action is planned. customer-reported

Comments

@shvmgpt116
Copy link

I see following git tests are not present in either of the EFCore 7 released versions. They are present in EFCore 8 preview version.

JsonQuerySqlServerTest.Json_collection_element_access_in_predicate_using_ElementAt
JsonQuerySqlServerTest.Json_collection_element_access_in_predicate_nested_mix
JsonQuerySqlServerTest.Json_boolean_predicate

It seems earlier they were included in efcore 7 development code. Is my understanding correct?
If yes, Please could someone clarify why they have been removed in EFCore 7.
Are these features/LINQs not supported in EFCore 7 and will be supported in EFCore 8?
Or is there some other reason?

@roji
Copy link
Member

roji commented May 16, 2023

Using git blame shows that test Json_collection_element_access_in_predicate_using_ElementAt was added in commit 94be38c; this is the implementation of issue #28648, which was release in 8.0-preview1. So this is functionality which was added for 8.0.

@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
@ajcvickers ajcvickers added the closed-no-further-action The issue is closed and no further action is planned. label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-no-further-action The issue is closed and no further action is planned. customer-reported
Projects
None yet
Development

No branches or pull requests

3 participants