Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InMemory: A better implementation of DefaultIfEmpty #17536

Closed
smitpatel opened this issue Aug 31, 2019 · 1 comment
Closed

InMemory: A better implementation of DefaultIfEmpty #17536

smitpatel opened this issue Aug 31, 2019 · 1 comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@smitpatel
Copy link
Contributor

Currently DefaultIfEmpty marks everything coming out as nullable and inject a null values valueBuffer.
But certain correlated query it fails. In following case, City comes from outer and even though there is DefaultIfEmpty, we still read value from outer valueBuffer.

            return AssertQuery<Customer, Order>(
                isAsync,
                (cs, os) => from c in cs
                            from o in os.Where(o => c.CustomerID == o.CustomerID).Select(o => c.City).DefaultIfEmpty()
                            select new
                            {
                                c,
                                o
                            },
                entryCount: 91);
@ajcvickers ajcvickers added this to the Backlog milestone Sep 6, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@ajcvickers ajcvickers modified the milestones: 6.0.0, Backlog Nov 6, 2020
@ajcvickers ajcvickers added propose-close closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. and removed type-enhancement propose-close area-query area-in-memory labels Oct 20, 2022
@ajcvickers
Copy link
Contributor

We recommend against using the in-memory provider for testing--see Testing EF Core Applications. While we have no plans to remove the in-memory provider, we will not be adding any new features to this provider because we believe valuable development time is better spent in other areas. When feasible, we plan to still fix regressions in existing behavior.

@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 26, 2022
@ajcvickers ajcvickers removed this from the Backlog milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Development

No branches or pull requests

2 participants