Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak collections not included in group join #12583

Closed
AndriySvyryd opened this issue Jul 6, 2018 · 7 comments
Closed

Weak collections not included in group join #12583

AndriySvyryd opened this issue Jul 6, 2018 · 7 comments
Labels
area-query closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. punted-for-2.2 punted-for-3.0 type-bug

Comments

@AndriySvyryd
Copy link
Member

See ComplexNavigationsWeakQueryTestBase.Include_with_groupjoin_skip_and_take
@ajcvickers ajcvickers added this to the 2.2.0 milestone Jul 6, 2018
@AndriySvyryd
Copy link
Member Author

The problem is in NavigationRewritingExpressionVisitor.RewriteNavigationProperties: it doesn't update the include result operator if the navigation gets rewritten into something that's not a naked qsre. And this is more common for weak/owned entity types.

The fix is to find the qsre in any expression that the rewriter produces.

@AndriySvyryd AndriySvyryd changed the title Weak collections not inluded in subqueries Weak collections not included in groupgoin Jul 10, 2018
@AndriySvyryd AndriySvyryd changed the title Weak collections not included in groupgoin Weak collections not included in group join Jul 10, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0, 3.0.0 Aug 3, 2018
@ajcvickers ajcvickers modified the milestones: 3.0.0, 2.2.0 Aug 3, 2018
@maumar
Copy link
Contributor

maumar commented Aug 23, 2018

Problem is actually somewhere else. Initially, when we construct Inlcude trees we can't associate qsre from grouping

join Level1 l1 in value(EntityQueryable`1[Level1]) on [t].OneToOne_Required_PK1?.Level1_Optional_Id equals Convert([l1].Id) into IEnumerable`1 grouping

with the qsre that include operator was declared on:

from Level1 t in value(EntityQueryable`1[Level1])

@maumar
Copy link
Contributor

maumar commented Aug 28, 2018 •
edited
Loading

example that doesn't involve weak collections: #13083

@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Sep 11, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0, 3.0.0 Oct 3, 2018
@AndriySvyryd AndriySvyryd removed their assignment Oct 25, 2018
@ajcvickers ajcvickers removed this from the 3.0.0 milestone Jun 28, 2019
@ajcvickers ajcvickers added this to the Backlog milestone Jun 28, 2019
@AndriySvyryd
Copy link
Member Author

Blocked by the decision on #17068

@smitpatel
Copy link
Contributor

@AndriySvyryd - decision on #17068 has been made. What should we do with this now?

@AndriySvyryd
Copy link
Member Author

Can close and delete/disable the test

@smitpatel
Copy link
Contributor

Removed in #19017

@smitpatel smitpatel removed this from the Backlog milestone Nov 22, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. punted-for-2.2 punted-for-3.0 type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajcvickers @smitpatel @maumar @AndriySvyryd