Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Port environment variable workaround in Aspire Dashboard images #5190

Closed
lbussell opened this issue Feb 12, 2024 · 5 comments
Closed
Assignees

Comments

@lbussell
Copy link
Contributor

Original issue: #5164

The Aspire Dashboard Dockerfiles currently contain a workaround for a port environment variable issue with the Aspire Dashboard:

ASPNETCORE_URLS=http://0.0.0.0:18888 \
DOTNET_DASHBOARD_OTLP_ENDPOINT_URL=http://0.0.0.0:18889 \

I did not find a tracking issue for this on the Aspire repo but presumably it will be fixed eventually. We want all port/URL environment variables to have the shorthand format:

@lbussell
Copy link
Contributor Author

[Triage] @joperezr, can you make this change when the correct fix is in Aspire? I didn't find a tracking issue for it.

@lbussell lbussell moved this from Backlog to Current Release in .NET Docker Feb 15, 2024
@joperezr
Copy link
Member

Yup, will do.

@lbussell
Copy link
Contributor Author

lbussell commented Aug 19, 2024

@joperezr is this fixed in Aspire Dashboard yet? Please link a tracking issue from the Aspire repo.

@lbussell lbussell moved this from Current Release to Backlog in .NET Docker Aug 19, 2024
@JamesNK
Copy link
Member

JamesNK commented Sep 27, 2024

Hi, I don't know of a tracking issue for this in dotnet/aspire, but I'm fixing it here: dotnet/aspire#5941

It should be fixed for Aspire 9.0.

@lbussell lbussell moved this from Backlog to Current Release in .NET Docker Sep 27, 2024
@lbussell lbussell moved this from Current Release to Sprint in .NET Docker Oct 14, 2024
@lbussell lbussell moved this from Sprint to In Progress in .NET Docker Oct 15, 2024
@lbussell
Copy link
Contributor Author

Fixed in #5980

@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Docker Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants