Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoDigitYearMax breaking change #33718

Merged
merged 4 commits into from
Jan 26, 2023
Merged

TwoDigitYearMax breaking change #33718

merged 4 commits into from
Jan 26, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 26, 2023

Fixes #31978

Preview

@dotnet-bot dotnet-bot added this to the January 2023 milestone Jan 26, 2023
@gewarren gewarren changed the title wodigityearmax breaking change TwoDigitYearMax breaking change Jan 26, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Jan 26, 2023
@gewarren gewarren requested review from tarekgh and a team January 26, 2023 19:55
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I replied to your comments.

thanks @gewarren

@gewarren gewarren enabled auto-merge (squash) January 26, 2023 23:18
@gewarren gewarren merged commit 0cb33b6 into dotnet:main Jan 26, 2023
@gewarren gewarren deleted the twodigit branch January 26, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking change]: TwoDigitYearMax default value changed from 2029 to 2049 in Gregorian based calendars
3 participants