Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breaking change]: System.Windows.Extensions package no longer references System.Drawing.Common #37525

Closed
1 of 3 tasks
ericstj opened this issue Oct 16, 2023 · 1 comment · Fixed by #37889
Closed
1 of 3 tasks

[Breaking change]: System.Windows.Extensions package no longer references System.Drawing.Common #37525

ericstj opened this issue Oct 16, 2023 · 1 comment · Fixed by #37889
Assignees
@gewarren
Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 8 Work items for the .NET 8 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. source incompatible Source code may encounter a breaking change in behavior when targeting the new version.

Comments

@ericstj
Copy link
Member

ericstj commented Oct 16, 2023 •
edited by github-actions bot
Loading

Description

The System.Windows.Extensions package no longer references the System.Drawing.Common package.

Version

.NET 8 Preview 7

Previous behavior

The System.Windows.Extensions package referenced the System.Drawing.Common package.

New behavior

The System.Windows.Extensions package no longer references the System.Drawing.Common package. If you depended on this package reference bringing in System.Drawing.Common it will no longer do so.

You may see a compilation error like:

error CS1069: The type name 'FontConverter' could not be found in the namespace 'System.Drawing'. This type has been forwarded to assembly 'System.Drawing.Common, Version=0.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' Consider adding a reference to that assembly.

Or complaints of other missing types in System.Drawing.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code may require source changes to compile successfully.
  • Behavioral change: Existing binaries may behave differently at run time.

Reason for change

This avoids a dependency on System.Drawing.Common when System.Windows.Extensions is referenced.

This will help more components remove a dependency on System.Drawing.Common unless they actually need it. See dotnet/msbuild#8962.

Recommended action

If you still need to use System.Drawing.Common add a direct reference.

Feature area

Windows Forms

Affected APIs

No response

Associated WorkItem - 177288
@ericstj ericstj added doc-idea Indicates issues that are suggestions for new topics [org][type][category] breaking-change Indicates a .NET Core breaking change Pri1 High priority, do before Pri2 and Pri3 labels Oct 16, 2023
@dotnet-bot dotnet-bot added source incompatible Source code may encounter a breaking change in behavior when targeting the new version. ⌚ Not Triaged Not triaged labels Oct 16, 2023
@ericstj
Copy link
Member Author

ericstj commented Oct 16, 2023

Change introduced in dotnet/runtime#88157

@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Oct 16, 2023
@gewarren gewarren added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Oct 31, 2023
@github-actions github-actions bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Nov 1, 2023
@gewarren gewarren added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Nov 2, 2023
@gewarren gewarren moved this from 🔖 Ready to 👀 In review in dotnet/docs November 2023 sprint Nov 3, 2023
@gewarren gewarren mentioned this issue Nov 3, 2023
Merged
@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Nov 3, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in .NET 8.0 work items Nov 7, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs November 2023 sprint Nov 7, 2023
@ghost ghost removed the in-pr This issue will be closed (fixed) by an active pull request. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gewarren gewarren

Labels
breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 8 Work items for the .NET 8 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. source incompatible Source code may encounter a breaking change in behavior when targeting the new version.
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
dotnet/docs November 2023 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

System.Windows.Extensions dependency breaking change gewarren/docs
3 participants
@ericstj @dotnet-bot @gewarren