Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: WCF Client RC 6.0 RC Release #34909

Closed
1 of 3 tasks
HongGit opened this issue Apr 6, 2023 · 0 comments · Fixed by #34914
Closed
1 of 3 tasks

[Breaking change]: WCF Client RC 6.0 RC Release #34909

HongGit opened this issue Apr 6, 2023 · 0 comments · Fixed by #34914
Assignees
Labels
breaking-change Indicates a .NET Core breaking change 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@HongGit
Copy link
Contributor

HongGit commented Apr 6, 2023

Description

WCF Client 6.0 RC Release.

Previously when using Duplex contract, failure to capture synchronization context on channel factory open. The behavior now matches .NET framework, by default, we will now capture the synchronization context, and will dispatch callbacks to the captured context. To revert to 4.x behavior, apply the CallbackBehaviorAttribute with the UseSynchronizationContext property set to false.

Version

Other (please put exact version in description textbox)

Previous behavior

Previously when using Duplex contract, failure to capture synchronization context on channel factory open.

New behavior

The behavior now matches .NET framework, by default, we will now capture the synchronization context, and will dispatch callbacks to the captured context.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code may require source changes to compile successfully.
  • Behavioral change: Existing binaries may behave differently at run time.

Reason for change

Bug fix PR . The new behavior now matches .NET framework.

Recommended action

To revert to 4.x behavior, apply the CallbackBehaviorAttribute with the UseSynchronizationContext property set to false.

Feature area

WCF Client

Affected APIs

DuplexChannelFactory<TChannel>.Open
DuplexChannelFactory<TChannel>.BeginOpen/EndOpen

Associated WorkItem - 86272

@HongGit HongGit added doc-idea breaking-change Indicates a .NET Core breaking change labels Apr 6, 2023
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Apr 6, 2023
@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Apr 6, 2023
@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Apr 6, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in dotnet/docs April 2023 sprint Apr 8, 2023
@ghost ghost removed the in-pr This issue will be closed (fixed) by an active pull request. label Apr 8, 2023
@gewarren gewarren added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Apr 20, 2023
@github-actions github-actions bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates a .NET Core breaking change 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants