Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn components multi-targeting needs to be documented #27943

Open
Youssef1313 opened this issue Jan 24, 2022 · 3 comments
Open

Roslyn components multi-targeting needs to be documented #27943

Youssef1313 opened this issue Jan 24, 2022 · 3 comments

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 24, 2022

The work done in dotnet/sdk#20793 should be documented. Points that should be covered:

  • Why/when multi-targeting is needed.
  • How to include different versions in both cases when SDK supports components multi-targeting (SupportsRoslynComponentVersioning is true) and when it's false.
  • How to handle Roslyn APIs that exists in a newer version but not an older one.

The article can go in https://github.com/dotnet/docs/tree/main/docs/csharp/roslyn-sdk and be linked from source generators article and analyzer/codefix article.

cc @eerhardt in case you want to work on the documentation.

@BillWagner
Copy link
Member

Thanks for adding this @Youssef1313

I've added it to our backlog.

@Youssef1313
Copy link
Member Author

For reference: a commit that has moved to multi-targeting is YairHalberstadt/stronginject@40c2721

Tagging @jnm2 in case you wanted to contribute the article :)

@jnm2
Copy link
Contributor

jnm2 commented Jan 26, 2022

One thing I haven't done yet but want to try is multitargeting Roslyn v2 and v3 in one package. That requires a .targets that's a bit more involved than "If not SupportsRoslynComponentVersioning then delete roslyn4."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants