improve warning message about global namespace class #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,9 +130,10 @@ public override MetadataItem VisitAssembly(IAssemblySymbol symbol) | |||
| item.Type = MemberType.Assembly; | |||
| _references = new Dictionary<string, ReferenceItem>(); | |||
| var namespaces = symbol.GlobalNamespace.GetNamespaceMembers().ToList(); | |||
| if (namespaces.Count == 0) | |||
| var allMembers = symbol.GlobalNamespace.GetMembers().ToList(); | |||
There was a problem hiding this comment.
how about getting the non namespace members directly?
|
👍 |
| { | ||
| Logger.LogWarning($"No namespace is found in assembly {symbol.MetadataName}. DocFX currently only supports generating metadata with namespace defined."); | ||
| Logger.LogWarning($"DocFX currently only supports generating metadata with namespace defined. The following types in assembly \"{symbol.MetadataName}\" will have no metadata generated: {string.Join(", ", allMembers.Except(namespaces).Select(m => m.MetadataName))}. "); |
There was a problem hiding this comment.
how about using \n{string.Join("\t")} to make warning message more readable when there're too many non namespace members?
|
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #417
@chenkennt @vwxyzh @ansyral @hellosnow @qinezh