Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-trace doesn't provide feedback when the end of collection process has begun #717

Closed
acolombi opened this issue Dec 21, 2019 · 1 comment · Fixed by #721
Closed
Assignees
Labels
dotnet-trace enhancement New feature or request

Comments

@acolombi
Copy link

When the user presses "Enter" to end collection, dotnet-trace doesn't indicate it's received the event. I was in an environment where the shutdown sequence was slower than usual, and I actually thought dotnet-trace wasn't receiving the "Enter" command. In my development environment it only took a few seconds between pressing "Enter" and getting confirmation that the profile was complete. In this environment it took 1 minute. It took me awhile to realize it was just slow, and not ignoring my request.

I recommend giving some output so the user knows dotnet-trace has entered its shutdown phase and is wrapping things up.

@sywhang
Copy link
Contributor

sywhang commented Dec 21, 2019

Thanks for the great feedback @acolombi!

@sywhang sywhang added the enhancement New feature or request label Dec 21, 2019
@sywhang sywhang self-assigned this Dec 24, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dotnet-trace enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants