Decompilation does not support "collapse to definitions"

[CyrusNajmabadi]

For example, Decompile "ImmutableArray". Now try to collapse to definitions. The option is in the menu, but it has no effect. This makes decompile a pretty poor MAS replacement as it's super hard to actually get a sense of all the structure of the type.

What is also weird is that some things are collapsed in the decompile view. For example:

The attributes are collapsed. However:

1. The comments are not collapsible.
2. Class bodies and method bodies are not collapsible.

I actually have no idea what's going on, but it's not good :)

[CyrusNajmabadi]

Also: disabling "navigate to external sources" has no effect. Even if i disable it, if i try to go back to ImmutableArray, it takes me back to this file.

[CyrusNajmabadi]

Tagging @sharwell . This is related to: dotnet/roslyn#26426

Namely that decompilation should not hijack MAS while the experience is so jarringly poor (comparatively).

[CyrusNajmabadi]

Here is the experience i get with MAS:

I would love if we could be very close to that, just with actual decompiled code.

[yaakov-h]

Umm... isn’t this a Roslyn/IDE issue?

[CyrusNajmabadi]

Damnit.

[CyrusNajmabadi]

Ported to: dotnet/roslyn#26436

Closing this out.

[CyrusNajmabadi]

Thanks @yaakov-h