Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compilation from CodeDOM #24269

Closed
terrajobst opened this issue Nov 28, 2017 · 2 comments
Closed

Enable compilation from CodeDOM #24269

terrajobst opened this issue Nov 28, 2017 · 2 comments

Comments

@terrajobst
Copy link
Contributor

Reported by @jlahteen:

However, the current version of System.CodeDom throws PlatformNotSupported for every CompileAssembly* method of CSharpCodeGenerator since they all end up to the method FromFileBatch which throws that exception systematically. Just wondering whether this is still the current state of development or should it already work. Everything works well in my experiment project if I just change the target framework from netcoreapp2.0 to net462.

That's unfortunately by-design as the compilers are not part of the .NET Core runtime. However, given that CodeDOM isn't referenced by the core (it only comes in when people depend on it/via the compat pack) we could probably fix this.

@weshaggard, any reason why the CodeDOM NuGet package couldn't depend on Roslyn? Practically speaking, folks depending on CodeDOM probably need to compile anyways so probably end up pulling in Roslyn anyway. The benefit of us doing it avoids consuming code having to pipe the data & settings correctly through to Roslyn.

@stephentoub
Copy link
Member

stephentoub commented Nov 28, 2017

@karelz
Copy link
Member

karelz commented Nov 29, 2017

Closing as duplicate of #18768

@karelz karelz closed this as completed Nov 29, 2017
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants