-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port S.Ref.StrongNameKeyPair #18349
Comments
@bartonjs any thoughts one whether or not we have enough Crypto to support this x-plat? |
@dsplaisted, I ported https://github.com/dsplaisted/strongnamer to netstandarad1.3. This is the only blocker. Basically this is the patch so far: https://gist.github.com/jasonwilliams200OK/181721c2fcd6dcf995440f2dfde1f0de -- Mono.Cecil (released just now -> jbevain/cecil#213 (comment)) and Microsoft.Build.* are now published to NuGet.org with netstandard support |
Can we get some clarity on whether the ask is just for StrongNameKeyPair (hopefully can be implemented as standlone), or also a request for AssemblyName.get_KeyPair as well? (which would mean jamming StrongNameKeyPair and whatever associated crypto comes with it) into the S.Private area? It sounds like the former to me, but it would be good to get clarity. |
@atsushikan, for StrongNamer project, KeyPair getter is not required (might be blocking someone else but that can probably be worked out later once the related Cryptography APIs are available xplat). |
@weshaggard Ignoring the potential question of layering (which Ati covered) think it's "named keys are very much tied to CAPI, and can't work x-plat; and the keypair blob form is probably transparently the CAPI form, so they'd need to reuse the CAPI <--> RSAParameters conversion logic; and otherwise it's fine". |
Is it a correct assessment that the dependency |
This is covered by https://github.com/dotnet/corefx/issues/11808. @kouvel please close if you agree. |
Yes this should be covered by dotnet/corefx#11808, closing |
@kouvel we should make sure that what we do in dotnet/corefx#11808 actually provides a working version of StrongNameKeyPair because currently I don't think it is functional. |
Any input on implementing S.R.StrongNameKeyPair? We are also trying to build StrongNamer in a .NET Standard MSBuild Task, but got into a PlatformNotSupported exception in this class in Linux. I think that this class could possibly be implemented, as assemblies can be strong named when built on Linux. |
This type is used by MSBuild and disabled for xplat. Now that Microsoft.Build.Framework is available as an official NuGet package, some libs depending on MSBuild are being ported to .NET Core; lack of this type is a show-stopper in some cases. :(
cc @weshaggard, @atsushikan, dotnet/coreclr#6614 (comment)
The text was updated successfully, but these errors were encountered: