This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Expose serialization primitives from System.Private.Corelib #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build break - |
|
LGTM otherwise. |
stephentoub
force-pushed
the
serialization_modelxml
branch
from
c6006ee to
d08e4c9
Compare
- Update the model.xml file to expose the serialization primitives from the runtime, e.g. [Serializable], [NonSerialized], ISerializable, etc. - Tweak how FEATURE_SERIALIZATION is used on some types. ISerializable and IDeserializationCallback are not ifdef'd based on FEATURE_SERIALIZATION, but their members are, which means there are some types which are implementing the interface but have the implementation of the interface's method ifdef'd. This commit removes the ifdef'ing of the methods on the interface, and then ifdef's the implementation of the interface on the offending types.
stephentoub
force-pushed
the
serialization_modelxml
branch
from
d08e4c9 to
292d4ea
Compare
…reCLR It brings in an FCall not available on coreclr.
| <Member Name="ToInt16(System.Object)" /> | ||
| <Member Name="ToUInt16(System.Object)" /> | ||
| <Member Name="ToInt32(System.Object)" /> | ||
| <Member Name="ToUInt32(System.Object)" /> |
There was a problem hiding this comment.
ToUInt32 [](start = 20, length = 8)
nit, it's nice to use alpha order because it makes it easier to diff with the tooling generated one. fine either way though.
<Type Name="System.Runtime.Serialization.IFormatterConverter">
<Member Name="Convert(System.Object,System.Type)" />
<Member Name="Convert(System.Object,System.TypeCode)" />
<Member Name="ToBoolean(System.Object)" />
<Member Name="ToByte(System.Object)" />
<Member Name="ToChar(System.Object)" />
<Member Name="ToDateTime(System.Object)" />
<Member Name="ToDecimal(System.Object)" />
<Member Name="ToDouble(System.Object)" />
<Member Name="ToInt16(System.Object)" />
<Member Name="ToInt32(System.Object)" />
<Member Name="ToInt64(System.Object)" />
<Member Name="ToSByte(System.Object)" />
<Member Name="ToSingle(System.Object)" />
<Member Name="ToString(System.Object)" />
<Member Name="ToUInt16(System.Object)" />
<Member Name="ToUInt32(System.Object)" />
<Member Name="ToUInt64(System.Object)" />
</Type>
There was a problem hiding this comment.
Ok. If I need to rev it again, I can reorder it. I was just following the order from the source. If it goes in like this, it's also fine for whoever revs it next via a tool to accept any reordering that comes with that.
|
|
|
Looks good. |
|
Thanks. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…_modelxml Expose serialization primitives from System.Private.Corelib Commit migrated from dotnet/coreclr@2a1fd93
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @jkotas, @danmosemsft
After this, we can: