Unit tests for code under src/gc/ and ./src/pal/src/misc/ ?

[omajid]

I am looking to port the changes in dotnet/corefx#39686 to coreclr too. The coreclr code is getting a bit hairy and adding unit tests would give me confidence that everything is working as designed.

I am modifying these two files:

./src/gc/unix/cgroup.cpp
./src/pal/src/misc/cgroup.cpp

Are there existing unit tests (as in, tests that always run, irrespective of the environment) for these two files? If not, where would be the best place to add them?

[omajid]

Additional question: there's a file src/pal/tests/palsuite/miscellaneous/CGroup/test1/test.cpp. This isn't a unit test, is it? It requires some setup which means it's too environment dependent to be a useful unit test.

[Maoni0]

so recently we've been working on open sourcing our perf test suite that should be used for something like this. @andy-ms is the main contact on that. it will include container testing. he's out sick today but I will check with him where he's at wrt that when he's in.
CC-ing @sergiy-k.

[omajid]

Hey folks! It's been a few months and I want to circle back here.

I am looking for any pointers/docs/examples for testing cgroupv2 support. I am happy to implement both unit and performance tests to make sure cgroupv2 is support by coreclr.

@andy-ms, Are there any open source-perf tests I can base off of? Could you point me to any examples/docs for these perf tests?

Also, I think we are getting late with this, because Fedora 31 is about to be released. Fedora 31 only supports cgroupv2 out of the box and makes using coreclr in a container context harder than it needs to be.

[ghost]

There are GC performance tests at https://github.com/dotnet/performance/tree/master/src/benchmarks/gc . There is a tutorial in the README that can help get you started. Let me know if you need any help using this.

[Maoni0]

this was open sourced so closing this...if you have problems running the perf suite (explained in the readme from the link @andy-ms mentioned above please feel free to open an issue at the dotnet/performance repo.