Globalization API optimization opportunities

[jkotas]

From dotnet/coreclr#17029 (comment)

• Speculatively allocate array for LCMapStringEx / GetSortKey during case-insensitive hashing
• Do not use SafeHandle for sort handle on Unix (we are not using SafeHandle for this on Windows either)
• Use arguments that do not require marshaling in globalization API signature (pointers instead of strings, etc.)

[tarekgh]

Do not use SafeHandle for sort handle on Unix (we are not using SafeHandle for this on Windows either)

I think we still need the safe handle on Linux. sorting handle on Linux needs to be closed when done using it which is different than Windows.

https://github.com/dotnet/coreclr/blob/57ee22e6086af5dfc06651dc002e24a71c3999ee/src/mscorlib/shared/Interop/Unix/System.Globalization.Native/Interop.Collation.cs#L75

[jkotas]

CultureInfos are cached in a global hashtable and pretty much never disposed. Two interlocked operations for every globalized string operations is a pretty steep price to pay to handle the very rare case when the CultureInfos are disposed. There are other ways to deal with this than safe handle.

[tarekgh]

CultureInfos are cached in a global hashtable and pretty much never disposed

It is possible to get disposed. Also, it is possible creating different CompareInfo objects which can get collected and leak sort handles

https://github.com/dotnet/coreclr/blob/a4af006ff55af59ac5d28f0b4faffdc1806dc89a/src/mscorlib/src/System/Globalization/CultureInfo.cs#L707

new CultureInfo("en-US", false).CompareInfo

We may look at caching the sort handles in Linux too.

[dotnet-policy-service]

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

[dotnet-policy-service]

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.