This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Fixup project templates to handle project names with dashes #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danroth27
force-pushed
the
danroth27/hyphen-in-name
branch
2 times, most recently
from
d457a80
to
9eb6171
Compare
danroth27
changed the title
rynowak
reviewed
Apr 30, 2018
| var segments = baseNamespace.Split(NamespaceSeparators, StringSplitOptions.RemoveEmptyEntries); | ||
| builder.Append(CSharpIdentifier.SanitizeClassName(segments[0])); | ||
| if (segments.Length > 1) | ||
| { |
There was a problem hiding this comment.
If is not necessary. The loop will noop if the length == 0.
danroth27
force-pushed
the
danroth27/hyphen-in-name
branch
from
3e156cc
to
fe10fb0
Compare
|
🆙📅 |
rynowak
reviewed
May 1, 2018
| var type = Assert.Single(result.Assembly.GetTypes()); | ||
| Assert.Equal(expectedNamespace, type.Namespace); | ||
| Assert.Equal(expectedClassName, type.Name); | ||
| } |
SteveSandersonMS
pushed a commit
to SteveSandersonMS/BlazorMigration
that referenced
this pull request
Nov 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This template update is a partial fix for when the project name has a dash in it.
It's only a partial fix because it doesn't address sanitizing the namespace for the generated component classes. @rynowak Is this something you could help me out with?