Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Pass list of embedded resources candidate assemblies via temp file in intermediate dir #561

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Pass list of embedded resources candidate assemblies via temp file in intermediate dir #561

merged 1 commit into from
Apr 13, 2018

Conversation

SteveSandersonMS
Copy link
Member

Fixes #554

@SteveSandersonMS
Copy link
Member Author

We should include this in 0.2.0, otherwise more people will hit the problem soon.

@SteveSandersonMS SteveSandersonMS merged commit 38f1355 into dev Apr 13, 2018
@SteveSandersonMS SteveSandersonMS deleted the stevesa/fix-554 branch April 13, 2018 15:55
@SteveSandersonMS
Copy link
Member Author

Merged so we can move towards a final RC build, but @rynowak @javiercn please do leave review comments if you have any or if you have concerns about including this.

rynowak
rynowak reviewed Apr 13, 2018
View reviewed changes
Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@marcusbooyah marcusbooyah mentioned this pull request Oct 27, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rynowak rynowak rynowak left review comments

@javiercn javiercn Awaiting requested review from javiercn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveSandersonMS @rynowak