Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AspNetCoreModule should constrain its JobObject's memory to IIS settings #7029

Open
benaadams opened this issue Jan 25, 2019 · 2 comments
Open
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. feature-iis Includes: IIS, ANCM severity-nice-to-have This label is used by an internal tool
Milestone

Comments

@benaadams
Copy link
Member

benaadams commented Jan 25, 2019

If set Private Memory Limit so the GC can operate within those constraints

image

@shirhatti shirhatti added area-servers feature-iis Includes: IIS, ANCM labels Jan 25, 2019
@shirhatti shirhatti added this to the Backlog milestone Jan 30, 2019
@shirhatti
Copy link
Contributor

@Maoni0 Is there anything we need to do when hosting the coreclr in our own process? Or is the GC already JobObject aware?

@benaadams
Copy link
Member Author

GC is JobObject aware; however you need to start the process in the JobObject rather than applying it to the running process

From @Maoni0 #3409 (comment)

also I've seen this WindowsJobLock tool used by folks - this is NOT going to work for limiting GC heap usage because the physical limit is read when the runtime is loaded. if you wait till the process is already running and then specify the limits they are not going to get read, period.

@jkotalik jkotalik added affected-very-few This issue impacts very few customers bug This issue describes a behavior which is not expected - a bug. severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-very-few This issue impacts very few customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions bug This issue describes a behavior which is not expected - a bug. feature-iis Includes: IIS, ANCM severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

4 participants