Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and fix tests that do synchronous request and response IO #5899

Closed
halter73 opened this issue Jun 30, 2017 · 1 comment
Closed

Identify and fix tests that do synchronous request and response IO #5899

halter73 opened this issue Jun 30, 2017 · 1 comment
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Done This issue has been fixed task

Comments

@halter73
Copy link
Member

In preparation for defaulting AllowSynchronousIO to false we should identify and fix tests that call synchronous request and response Stream APIs.

Most Universe functional tests use Hosting's TestHost which doesn't need to change to disallow synchronous IO, but doing so allows us to potentially identify use cases (such as using DeflateStream) that make it difficult to avoid using synchronous IO.

Below are the test project that I saw fail when I modified TestHost not to allow sync request and response stream operations (excluding Flush). Here's the output showing each failed test.

[xUnit.net 00:00:04.0099135]   Finished:    Microsoft.AspNetCore.TestHost.Tests
Total tests: 51. Passed: 47. Failed: 4. Skipped: 0.

[xUnit.net 00:00:01.8295296]   Finished:    Microsoft.AspNetCore.Buffering.Tests
Total tests: 8. Passed: 7. Failed: 1. Skipped: 0.

[xUnit.net 00:00:03.3003836]   Finished:    Microsoft.AspNetCore.ResponseCaching.Tests
Total tests: 269. Passed: 231. Failed: 38. Skipped: 0.

[xUnit.net 00:03:20.8983023]   Finished:    ServerComparison.FunctionalTests
Total tests: 57. Passed: 34. Failed: 5. Skipped: 18.

[xUnit.net 00:00:03.9879504]   Finished:    Microsoft.AspNetCore.Diagnostics.Tests
Total tests: 75. Passed: 63. Failed: 12. Skipped: 0.

[xUnit.net 00:00:05.7808313]   Finished:    Microsoft.AspNetCore.Authentication.Test
Total tests: 224. Passed: 198. Failed: 24. Skipped: 2.

[xUnit.net 00:00:40.4557444]   Finished:    Microsoft.AspNetCore.Mvc.FunctionalTests
Total tests: 1015. Passed: 701. Failed: 314. Skipped: 0.

[xUnit.net 00:00:03.8723760]   Finished:    Microsoft.AspNetCore.Identity.InMemory.Test
Total tests: 190. Passed: 186. Failed: 4. Skipped: 0.

[xUnit.net 00:03:16.7483553]   Finished:    Entropy.FunctionalTests
Total tests: 270. Passed: 135. Failed: 25. Skipped: 110.
@aspnet-hello aspnet-hello transferred this issue from aspnet/Hosting Dec 18, 2018
@aspnet-hello aspnet-hello added this to the Backlog milestone Dec 18, 2018
@Tratcher
Copy link
Member

Dealt with back in #7644

@Tratcher Tratcher modified the milestones: Backlog, 3.0.0-preview3 Jun 19, 2019
@Tratcher Tratcher added the Done This issue has been fixed label Jun 19, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Done This issue has been fixed task
Projects
None yet
Development

No branches or pull requests

5 participants