From 3afbcded0170a7b7afd9ad6f8f1a40e7e37924db Mon Sep 17 00:00:00 2001
From: Safia Abdalla <safia@safia.rocks>
Date: Wed, 19 Jan 2022 05:19:04 +0000
Subject: [PATCH] Address initial feedback from API review

---
 .../Http.Extensions/src/HttpJsonServiceExtensions.cs | 12 +++++++-----
 src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt |  4 ++--
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs b/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs
index ad2ae3f87a86..ad7865d06dd2 100644
--- a/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs
+++ b/src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs
@@ -2,27 +2,29 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using Microsoft.AspNetCore.Http.Json;
-using Microsoft.Extensions.DependencyInjection;
 
-namespace Microsoft.AspNetCore.Http;
+namespace Microsoft.Extensions.DependencyInjection;
 
 /// <summary>
 /// Extension methods to configure JSON serialization behavior.
 /// </summary>
-public static class HttpJsonServiceExtensions
+public static class RouteHandlerJsonServiceExtensions
 {
+#pragma warning disable CS0419 // Ambiguous reference in cref attribute
     /// <summary>
     /// Configures options used for reading and writing JSON by route handlers.
     /// </summary>
     /// <remarks>
     /// The options configured here will only affect JSON returned and processed
-    /// from route handlers, not controllers.
+    /// from route handlers, not controllers, when using <see cref="System.Net.Http.Json.HttpContentJsonExtensions.ReadFromJsonAsync" />
+    /// and <see cref="Microsoft.AspNetCore.Http.HttpResponseJsonExtensions.WriteAsJsonAsync" />.
     /// </remarks>
     /// <param name="services">The <see cref="IServiceCollection" /> to configure options on.</param>
     /// <param name="configureOptions">The <see cref="Action{JsonOptions}"/> to configure the
     /// <see cref="JsonOptions"/>.</param>
     /// <returns>The modified <see cref="IServiceCollection"/>.</returns>
-    public static IServiceCollection ConfigureHttpJsonOptions(this IServiceCollection services, Action<JsonOptions> configureOptions)
+#pragma warning restore CS0419 // Ambiguous reference in cref attribute
+    public static IServiceCollection ConfigureRouteHandlerJsonOptions(this IServiceCollection services, Action<JsonOptions> configureOptions)
     {
         services.Configure<JsonOptions>(configureOptions);
         return services;
diff --git a/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt b/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt
index 5f38df127f40..1030d0f0793e 100644
--- a/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt
+++ b/src/Http/Http.Extensions/src/PublicAPI.Unshipped.txt
@@ -1,3 +1,3 @@
 #nullable enable
-Microsoft.AspNetCore.Http.HttpJsonServiceExtensions
-static Microsoft.AspNetCore.Http.HttpJsonServiceExtensions.ConfigureHttpJsonOptions(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<Microsoft.AspNetCore.Http.Json.JsonOptions!>! configureOptions) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
+Microsoft.Extensions.DependencyInjection.RouteHandlerJsonServiceExtensions
+static Microsoft.Extensions.DependencyInjection.RouteHandlerJsonServiceExtensions.ConfigureRouteHandlerJsonOptions(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<Microsoft.AspNetCore.Http.Json.JsonOptions!>! configureOptions) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!