Persist FPU variables across try_compile passes #12817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Mar 9, 2023
|
@jkoritzinsky, I don't have write permission. Can you please merge this? |
|
@am11 I am sorry for the delay with merging this, I was OOF and then sick for about two weeks. Merging now. |
|
Oops, I cannot merge it due to the arcade-ci leg failure. It is now strictly required to be green to allow merging. Let me try to rerun the failed legs. |
|
@janvorli, thank you! Hope you are feeling well and healthy. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
-cmakeargs -DCLR_ARM_FPU_TYPE=vfpv4is passed from command-line, the first pass to toolchain was failing the conditionif (NOT DEFINED CLR_ARM_FPU_TYPE)as expected, but the second and subsequent passes were satisfying the condition. This is because how cmake invokes the toolchain file.Append variables that we must persist across the passes to
CMAKE_TRY_COMPILE_PLATFORM_VARIABLESto override this behavior.Contributes to dotnet/runtime#83170.
cc @janvorli