Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix SDK fails to pull files from netcorenativeassets because of SSL errors #8703

Closed
Tracked by #9136
premun opened this issue Mar 31, 2022 · 7 comments
Closed
Tracked by #9136
Assignees

Comments

@premun
Copy link
Member

premun commented Mar 31, 2022

Seems like downloading of the profile can fail: dotnet/runtime#67349

##[error].packages/microsoft.dotnet.helix.sdk/7.0.0-beta.22179.1/tools/xharness-runner/XHarnessRunner.targets(122,5): error MSB4018: The "CreateXHarnessAppleWorkItems" task failed unexpectedly.
System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
 ---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid because of errors in the certificate chain: RevocationStatusUnknown
   at System.Net.Security.SslStream.SendAuthResetSignal(ProtocolToken message, ExceptionDispatchInfo exception)
   at System.Net.Security.SslStream.CompleteHandshake(SslAuthenticationOptions sslAuthenticationOptions)
   at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
   at System.Net.Http.ConnectHelper.EstablishSslConnectionAsync(SslClientAuthenticationOptions sslOptions, HttpRequestMessage request, Boolean async, Stream stream, CancellationToken cancellationToken)

It is failing the rolling build of runtime: https://dev.azure.com/dnceng/public/_build/results?buildId=1694490&view=logs&j=f4520fb1-1559-5885-1d9c-3cb3f6a85e23&t=6c7a8cfe-f92e-569a-eef9-b2ad3e13056d

@premun premun self-assigned this Mar 31, 2022
@premun premun changed the title Add retries for provisioning profile download Helix SDK fails to pull files from netcorenativeassets because of SSL errors Apr 4, 2022
@premun
Copy link
Member Author

premun commented Apr 4, 2022

There were no code changes in that area for month, I am suspecting that some agents might have problems with TLS 1.2 or something like that is happening

@premun
Copy link
Member Author

premun commented Apr 4, 2022

This happens on following agents:

Operating System

  • macOS 11.6.5 20G527

Virtual Environment

Virtual Environment Provisioner

  • 1.0.0.0-main-20220307-1
  • Current image version: '20220322.1'

@premun
Copy link
Member Author

premun commented Apr 7, 2022

Fix was merged, it now needs to flow to runtime and then we can monitor Kusto for the alerts:

TimelineIssues
| where Type == "error" and Message contains "CreateXHarnessAppleWorkItems"
| join kind=inner TimelineBuilds on BuildId
| where StartTime > now() - 7d
| order by StartTime desc
| project QueueTime, Project, Repository, Reason, BuildNumber, Definition, SourceBranch

If things are good for a couple of days, we can close this

@agocke
Copy link
Member

agocke commented Apr 14, 2022

Have we ever seen this on MacOS 12? Should we try moving to 12.0 build machines to see if that addresses the TLS failures?

@premun
Copy link
Member Author

premun commented Apr 19, 2022

We could but I think updating the SDK in runtime should do the trick too.

I understand you're blocked because of the .NET 7.0 bump but this PR should help:
dotnet/runtime#68024

For 12.00, we were not able to move originally as there were some blockers for MacCatalyt and iOS simulators but those have been resolved and we could do that as well. I don't know if it will help this issue though (we don't have data on this as it only manifests rarely).

@premun
Copy link
Member Author

premun commented Apr 20, 2022

This is blocked by dotnet/runtime#67771

@premun
Copy link
Member Author

premun commented Apr 27, 2022

There were no occurrences in the last 6 days so feels like the fix helped, closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants