Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up devdiv pool usage in official arcade templates #14651

Closed
2 tasks
riarenas opened this issue Mar 26, 2024 · 7 comments
Closed
2 tasks

Fix up devdiv pool usage in official arcade templates #14651

riarenas opened this issue Mar 26, 2024 · 7 comments
Assignees
Labels
1ES Template Migration Issues related to 1ES template migration

Comments

@riarenas
Copy link
Member

  • This issue is blocking
  • This issue is causing unreasonable pain

There is at least one instance of the official Arcade templates where we are using the incorrect pool and image combination: https://github.com/dotnet/arcade/blob/release/6.0/eng/common/templates-official/post-build/post-build.yml#L139-L141

We should go through the templates to make sure we're consistent in our choice of pool + image in devdiv.

@riarenas riarenas self-assigned this Mar 26, 2024
@riarenas riarenas added the 1ES Template Migration Issues related to 1ES template migration label Mar 26, 2024
@dougbu
Copy link
Member

dougbu commented Mar 26, 2024

@riarenas, could you please remove use of the -pt images while updating any other dotnet/arcade branch w/ this issue❔

@riarenas
Copy link
Member Author

I think that will make the changes larger than I want to target them. I'll scope this issue just to fixing real blocking issues with using non-compatible images.

@dougbu
Copy link
Member

dougbu commented Mar 26, 2024

well, 😦 I'll create another issue in this repo for -pt usage cleanup

@riarenas
Copy link
Member Author

6.0: #14654

@riarenas
Copy link
Member Author

riarenas commented Mar 26, 2024

I think it was good to create the other issue, I could only find the instances in #14654 for this issue. I'll work on #14652 next.

@dougbu
Copy link
Member

dougbu commented Mar 26, 2024

I'll work on #14652 next.

that one doesn't feel urgent to me. but if you have time 😁

@riarenas
Copy link
Member Author

I could only find two instances of broken pools. So I think this issue is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1ES Template Migration Issues related to 1ES template migration
Projects
None yet
Development

No branches or pull requests

2 participants