Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.0.1 has major memory retention problem but is not marked as deprecated #2177

Closed
Timo-Weike opened this issue Oct 10, 2023 · 4 comments

Comments

@Timo-Weike
Copy link

Timo-Weike commented Oct 10, 2023

The version 5.0.1 has the memory retention problem discussed in #1810, but dispite multiple comments suggesting that the version should be marked as deprecated or having a bug, the version is still up and unmarked on NuGet.

I just took some days to "rediscover" this problem and am grateful for it being already solved. However I think it would be very helpful for all users of the version.

And as you can see on the nuget stats page for the package, version 5.0.1 was downloaded over 3 million times in the last 6 weeks
image

So version 5.0.1 is far from not being used, but IMHO should be with this kind of problem.

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 10, 2023

A lot of downloads of this package come via EF Core 7 and the latest version of EF Core 7 was just Updated to use 5.11

@DavoudEshtehari DavoudEshtehari added 🆕 Triage Needed For new issues, not triaged yet. and removed 🆕 Triage Needed For new issues, not triaged yet. labels Oct 10, 2023
@DavoudEshtehari
Copy link
Contributor

Thank you for providing the feedbacks, we'll look into it and try to improve it on NuGet.org.

@Timo-Weike
Copy link
Author

Timo-Weike commented Dec 7, 2023

A lot of downloads of this package come via EF Core 7 and the latest version of EF Core 7 was just Updated to use 5.11

As of now the version 5.0.1 was still downloaded over 3 million times in the last 6 weeks
image

I think a deprecation flag would improve these numbers.

@David-Engel
Copy link
Contributor

I marked it as deprecated with a recommendation to update to at least 5.0.2: https://www.nuget.org/packages/Microsoft.Data.SqlClient/5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants